Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build instructions for OSX #342

Closed
joshdentremont opened this issue Jul 11, 2024 · 2 comments · Fixed by #355
Closed

Update build instructions for OSX #342

joshdentremont opened this issue Jul 11, 2024 · 2 comments · Fixed by #355

Comments

@joshdentremont
Copy link
Collaborator

Some of the instructions in the READMEs don't work on OSX. It would be nice if we could update them so they work for both OSX and Linux, or add new OSX instructions.

For example, I don't have wget on my machine, so when I want to generate a new SHA to update the version of something included in an image I need to modify the commands in the README. Instead of running wget --quiet "${URL}" I can run curl "${URL}" -o "${FILE}" which should work on Linux and OSX.

make bake also doesn't work for me, but docker buildx bake does.

I suspect there might be more, so it would be helpful to go through and test on OSX and Linux to make sure everything works as intended and update the docs accordingly.

@nigelgbanks
Copy link
Contributor

https://github.com/Islandora-Devops/isle-buildkit?tab=readme-ov-file#requirements

The README specifies the need for using brew on OSX to install the GNU version of make, I think this brings wget in as well, though I'm not 100% sure. I'll merge a pull to update the README to change wget for curl.

@joecorall
Copy link
Contributor

I think the only thing missing from the instructions for mac is needing to run this before make bake

docker context use default

joecorall added a commit that referenced this issue Nov 14, 2024
nigelgbanks pushed a commit that referenced this issue Nov 14, 2024
* Fix drush wrapper

* bump drupal core+drush test versions

* Fix test

* Close #342

* Do not break folks who haven't upgrade drush yet

* Update drush

* update composer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants