Cache poisoning issue.

[nigelgbanks]

          Hmmmm I'm not getting the same results from a fresh build?

• Reran make clean && make bake && make up

Check 1:

docker run --rm -d --name postgresql islandora/postgresql

docker exec -ti postgresql psql -U root postgres
psql (16.3)
Type "help" for help.

postgres=#

Check 2:

docker exec -ti postgresql bash

6f89c38c08af:/# postgres --version

postgres (PostgreSQL) 16.3

Originally posted by @g7morris in #346 (comment)

[nigelgbanks]

Both versions have the same release of alpine.

/ $ cat /etc/alpine-release 
3.19.1

So it has more to do with when it was built then the cache actually being poisoned. The shame is that the Alpine package repository is changing without a change in it's version number...

[joecorall]

Is it because we don't have base pinned to a specific tag? https://github.com/Islandora-Devops/isle-buildkit/blob/main/base/Dockerfile#L2

[nigelgbanks]

It's pined here: https://github.com/Islandora-Devops/isle-buildkit/blob/main/docker-bake.hcl#L301

It's because the alpine repository isn't idempotent for a given release, like 3.19.1 (which I didn't realize before). They reserve the right to update packages like postgresql without changing the alpine repository version number. For example, to add security patches and whatnot. I'm not sure if we can prevent this sort of thing from happening. We could pin every alpine package like postgresql, and then the build would break when alpine updates a package, like so:

/ # apk add postgresql=16.2
ERROR: unable to select packages:
  postgresql16-16.3-r0:
    breaks: world[postgresql=16.2]

But at that point we're just making work for ourselves for little gain. The only upside is that for a specific commit, of isle-buildkit we guarantee it produces the 100% the same image or fails to build. Though if we leave things as is, it should always build, but there might be minor version changes between alpine packages when built.

While I strived to make isle-buildkit close to idempotent as possible, it's a losing battle considering the additional effort. And we may just have to accept it as is.