changed matomo volume to only persist config directory #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not a huge concern for isle-build kit since it's only for testing. Though I think for isle-dc, and others it might be a problem as users can install plugins via the web-ui |
nigelgbanks
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the Matomo volume persist the entire /var/www/matomo directory causes problems when upgrading Matomo. This change should allow us to persist the config directory, which I believe is the only thing that needs to persist.
With this, when new Matomo images are created with new versions of Matomo, we should only need to run database updates.
This should prevent this issue: Islandora-Devops/isle-dc#361