Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag rendering in webvtt #116

Open
kimpham54 opened this issue Jan 9, 2018 · 0 comments
Open

tag rendering in webvtt #116

kimpham54 opened this issue Jan 9, 2018 · 0 comments

Comments

@kimpham54
Copy link
Member

From digitalutsc/islandora_web_annotations#216

Came out of the original interest to render tags from WebVTT files. Consider filter_xss() or other approach.

From @ulsdevteam and @bgilling:

In the “uls_install” branch of our code for islandora_solution_pack_oralhistories the transcripts_ui code has been removed as a submodule and treated like a regular drupal module (but kept as a dependency).

The function that I wrote to rewrite the tags as html is here: https://github.com/ulsdevteam/islandora_solution_pack_oralhistories/blob/uls_install/includes/utilities.inc#L297-L321 – and is called during the compose_vtt_transcript_as_transcripts_ui() routine above this (also in includes/utilities.inc).

In order to let the rewritten html through (the tag becomes a

), the filter_xss call is in here: transcript_ui/theme/transcripts_ui.theme.inc - https://github.com/ulsdevteam/transcripts_ui/blob/master/theme/transcripts_ui.theme.inc#L80.
Finally, these class names used in the

elements needed some styles – which I added to the bottom of the transcript_ui/css/transcripts-ui.css, like https://github.com/ulsdevteam/transcripts_ui/blob/master/css/transcripts-ui.css#L389-L395

@kimpham54 kimpham54 added this to the 7.x -1.10 Release milestone Jan 9, 2018
@kimpham54 kimpham54 modified the milestones: 7.x -1.10 Release, 7.x-1.11 Release Feb 16, 2018
@MarcusBarnes MarcusBarnes removed this from the 7.x-1.11 Release milestone Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants