Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a search engine closes the popup #5

Open
Istador opened this issue Sep 16, 2018 · 0 comments
Open

Selecting a search engine closes the popup #5

Istador opened this issue Sep 16, 2018 · 0 comments
Assignees
Labels
critical This is important enhancement New feature or request ux This affects how something is interacted with

Comments

@Istador
Copy link
Owner

Istador commented Sep 16, 2018

Currently, when a search engine is clicked on to select the default, the popup menu is closed.
For a better user experience, the popup should be left open.

The user should be able to change this behavior in the options (whether it should be open or closed after the click).


Technical:

The popup menu needs to be closed, because it's content isn't updated otherwise (the default search engine is displayed differently from the others, changing the default isn't updating the already opened popup menu).

When the popup menu is opened right after closing it, the click handler for the search engine is still executed and is trying to work on the old popup menu which results in an Error.

Maybe the popup's content can be updated manually, or the old popup can be hidden instead of closed, to prevent the Error.

@Istador Istador added the enhancement New feature or request label Sep 16, 2018
@Istador Istador self-assigned this Sep 16, 2018
@Istador Istador added ux This affects how something is interacted with critical This is important labels Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical This is important enhancement New feature or request ux This affects how something is interacted with
Projects
None yet
Development

No branches or pull requests

1 participant