New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HW07 30.10.17 #154

Open

Dzmitry-Lakisau opened this issue Nov 10, 2017 · 3 comments

Contributor

Dzmitry-Lakisau commented Nov 10, 2017

https://github.com/DzmitryLakisau/Last.fm-Library-Viewer/blob/master/README.md

Collaborator

alexdzeshko commented Nov 13, 2017

Naming convention
Repackage :
package.name.
data.
model, api, db ....
ui.
login, home, detail
activity, fragment,
util
ApiException : move message mapping upper to UI level (think about localization, resources)
About dialog remove unused views
Data: split to Model (POJO), DataLoader, HttpClient, Api (generate url), Parser, ImageLoader
Constants
Move async task from activity

TreeMap?

Contributor Author

Dzmitry-Lakisau commented Nov 13, 2017 •

edited

Loading

@alexdzeshko Concerning Imageloading. Is it better to make like in this two classes:
https://github.com/DzmitryLakisau/Last.fm-Library-Viewer/blob/refactor/app/src/main/java/by/d1makrat/library_fm/ImageDownloaderFromNetwork.java
https://github.com/DzmitryLakisau/Last.fm-Library-Viewer/blob/refactor/app/src/main/java/by/d1makrat/library_fm/AppSettings.java ?
Something needs to be improved?

Collaborator

alexdzeshko commented Nov 14, 2017

There will be a lesson about image loading next week, so skip this topic until it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment