Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardhat clean doesn't remove abis #49

Open
RyanRHall opened this issue May 24, 2023 · 1 comment
Open

hardhat clean doesn't remove abis #49

RyanRHall opened this issue May 24, 2023 · 1 comment

Comments

@RyanRHall
Copy link

I would expect the hardhat clean command to remove the generated abis, the same way that typechain hooks into the clean command and removes the code that it generates. Would be helpful when you've borked something and want to confirm that the state is fresh.

@ItsNickBarry
Copy link
Owner

This is something I've considered. However, I've never felt the need for this feature, and it would directly conflict with some of my use cases for the plugin. For example, see https://github.com/solidstate-network/solidstate-solidity. The ABIs are tracked in git and published as a package. If the abi/ directory were deleted, the package.json of that package would be deleted as well. Perhaps we could extend the behavior of the clear config option - check that each file is an ABI before deleting (it does this already), and then delete the directory if and only if it's empty. Then the question is whether to just make clear: true the default (or to remove the option altogether). Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants