Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol checks using iteration to load data assets results in check payloads binding last item in iteration #27

Open
J-81 opened this issue Feb 28, 2023 · 1 comment

Comments

@J-81
Copy link
Owner

J-81 commented Feb 28, 2023

This results in things like sample wise checks with data asset inclusive payloads to load the data asset associated with the last sample in the iteration for all samples.

What was intended was for the sample payload to load the data asset(s) associated with the sample in the current iteration.

Impact:

entity-wise checks were inappropriately supplying data assets from the last iteration for all entity instead of current iteration

In the current protocols this impacts:
Sample-wise checks

Visibility:

The evaluated payload is present the log and shows the improper data asset paths were loaded.

image

Solution:

ref: https://stackoverflow.com/a/10452866/16862353

Converting all lambda lines in protocol payloads from:

lambda: entity.data_assets["k"]
to
lambda entity=entity: entity.data_assets["k"]

This will ensure entity is dereferenced at lambda definition INSTEAD of dereferenced at lambda evaluation

@J-81
Copy link
Owner Author

J-81 commented Mar 6, 2023

Testing Fix:

Prior table example:
image
...
image

After fix table example:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant