Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_sample_in_multiqc_report() handling numeric sample names #47

Open
cyouh95 opened this issue Aug 15, 2024 · 0 comments
Open

check_sample_in_multiqc_report() handling numeric sample names #47

cyouh95 opened this issue Aug 15, 2024 · 0 comments

Comments

@cyouh95
Copy link

cyouh95 commented Aug 15, 2024

When sample names are numeric, samples below may be numeric while reformatted_multiQC_samples is string type, resulting in it thinking there are missing samples when there isn't:

missing_samples = set(samples) - set(reformatted_multiQC_samples)

Suggested fix:

missing_samples = set(map(str, samples)) - set(reformatted_multiQC_samples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant