-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use solid lines instead of dotted lines as grid lines #1202
Comments
… methods It was not used as parameter, instead always the property value of a property of the same class was passed.
Dotted lines are also very slow to draw with DirectX, which FMΧ uses on Windows. |
Hi I don't know if removing functionality that has been available for years is good. |
We sometimes have to move on, especially to keep the code maintainable. We can discuss about the tree lines, this issue covers only the grid lines, which should be handled separately from the tree lines. |
Issue #1088: Better visualize fixed columns
I separated drawing grid lines from drawing tree lines, we should not mix this. The change can still be reverted easily. I tested with some VCL themes and it looked good. Let me know what you think. |
Splitting them is good concept. |
It is quite unusual in year 2023 to use dotted lines instead of solid lines for visualizing grid lines. They add extra complexity, e.g. in the FMX port, see #1135, or when better visualizing fixed colors, see #1088.
I will therefore remove the dotted brush and use solid lines instead. They can also be easier scaled on displays >=175%, see issue #1203.
Furthermore, we should respect the theme when painting the grid lines, like we already do in the column header for the column separators.
The text was updated successfully, but these errors were encountered: