Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use solid lines instead of dotted lines as grid lines #1202

Closed
joachimmarder opened this issue Aug 2, 2023 · 5 comments
Closed

Use solid lines instead of dotted lines as grid lines #1202

joachimmarder opened this issue Aug 2, 2023 · 5 comments
Assignees
Labels
Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. VCL Themes
Milestone

Comments

@joachimmarder
Copy link
Contributor

joachimmarder commented Aug 2, 2023

It is quite unusual in year 2023 to use dotted lines instead of solid lines for visualizing grid lines. They add extra complexity, e.g. in the FMX port, see #1135, or when better visualizing fixed colors, see #1088.

I will therefore remove the dotted brush and use solid lines instead. They can also be easier scaled on displays >=175%, see issue #1203.

Furthermore, we should respect the theme when painting the grid lines, like we already do in the column header for the column separators.

@joachimmarder joachimmarder added the Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. label Aug 2, 2023
@joachimmarder joachimmarder self-assigned this Aug 2, 2023
joachimmarder added a commit that referenced this issue Aug 2, 2023
… methods

It was not used as parameter, instead always the property value of a property of the same class was passed.
@pyscripter
Copy link
Contributor

Dotted lines are also very slow to draw with DirectX, which FMΧ uses on Windows.

@livius2
Copy link
Contributor

livius2 commented Aug 2, 2023

Hi

I don't know if removing functionality that has been available for years is good.
I used custom patterns myself sometimes. And the scaling problem would have to be solved in a different way. Although the argument about slow line drawing cannot be ignored, but today's devices are getting more and more powerful ;-)
P.S. I thought I would be active this year, but it didn't work out, a lot of work. I hope I will find time to get back to the topic of FMX.

@joachimmarder
Copy link
Contributor Author

I don't know if removing functionality that has been available for years is good.

We sometimes have to move on, especially to keep the code maintainable. We can discuss about the tree lines, this issue covers only the grid lines, which should be handled separately from the tree lines.

joachimmarder added a commit that referenced this issue Aug 2, 2023
@joachimmarder joachimmarder added this to the V8.0 milestone Aug 2, 2023
@joachimmarder
Copy link
Contributor Author

I separated drawing grid lines from drawing tree lines, we should not mix this. The change can still be reverted easily. I tested with some VCL themes and it looked good. Let me know what you think.

@livius2
Copy link
Contributor

livius2 commented Aug 3, 2023

Splitting them is good concept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. VCL Themes
Projects
None yet
Development

No branches or pull requests

3 participants