Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract VST into VirtualTrees.StringTree.pas, leave VirtualTrees.pas as aggregate unit #1210

Open
Fr0sT-Brutal opened this issue Aug 10, 2023 · 3 comments
Open

Extract VST into VirtualTrees.StringTree.pas, leave VirtualTrees.pas as aggregate unit #1210

Fr0sT-Brutal opened this issue Aug 10, 2023 · 3 comments
Labels
Breaking Change Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. Pull Requests Invited There are no current plans to address the issue, but we would be happy if someone supplies a PR.

Comments

@Fr0sT-Brutal
Copy link
Contributor

Just an idea that won't change things much but will continue logical separation of various tree implementations.
As a downside - this probably will require a new entry in all packages
@joachimmarder
Copy link
Contributor

I like the idea, although I think we already have enough breaking changes in the upcoming V8.

@joachimmarder joachimmarder added Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. Breaking Change Pull Requests Invited There are no current plans to address the issue, but we would be happy if someone supplies a PR. labels Aug 13, 2023
@Fr0sT-Brutal
Copy link
Contributor Author

Well, if TVST will be redeclared in old unit, this won't be a breaking change AFAICS. Now VirtualTrees.pas contains only a few original public declarations as most of declarations are aliases. So just some more aliases. I'll make PR with this change for you to estimate required changes.

@joachimmarder
Copy link
Contributor

Maybe I should have left out the word "breaking". I have no intention to make this change myself for V8.0, but feel free to send a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. Pull Requests Invited There are no current plans to address the issue, but we would be happy if someone supplies a PR.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fr0sT-Brutal @joachimmarder