Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE9 Console Error breaks scripts/Sidebar subnavs #378

Open
RachelRVasquez opened this issue Sep 22, 2016 · 4 comments
Open

IE9 Console Error breaks scripts/Sidebar subnavs #378

RachelRVasquez opened this issue Sep 22, 2016 · 4 comments
Assignees

Comments

@RachelRVasquez
Copy link
Contributor

Noticed that there is a console error that may be interfering with the sidebar nav in IE9. We don't see the child pages in the subnav in IE9 only (screenshots below).

As for the rest, it's not immediately obvious until we've re-integrated a menu button to expand/collapse the sidebar menu on desktop, but the error will interfere with this as well ( once the PR is merged from #147 ).

screen shot 2016-09-22 at 1 45 03 am
screen shot 2016-09-22 at 1 44 55 am

@RachelRVasquez RachelRVasquez self-assigned this Sep 22, 2016
@RachelRVasquez
Copy link
Contributor Author

It looks like Prism JS for the syntax highlighter does not support IE9:

PrismJS/prism#987

There was a merge into Prism from the above thread, but when comparing the merge to the actual file in our node_modules folder for Prism JS, the code there doesn't match. Perhaps the npm version of prism is slightly out of date? I tried updating the npm version, but it looks like we're already using the latest.

The Prism Merge: PrismJS/prism@c9bdcd3

Our Version:

    if (document.addEventListener && !script.hasAttribute('data-manual')) {
        if(document.readyState !== "loading") {
            requestAnimationFrame(_.highlightAll, 0);
        }
        else {
            document.addEventListener('DOMContentLoaded', _.highlightAll);
        }
    }

Will hold on this for now so we can discuss options for approaching this. cc: @fuhton

@fuhton
Copy link
Contributor

fuhton commented Sep 23, 2016

@RachelRVasquez Have we updated the version in package.json?

@RachelRVasquez
Copy link
Contributor Author

@fuhton Yes I've tried to update it but we're already using the latest version. I meant that something with the npm version doesn't match what's in the Prism JS from their site, in spite of the npm version being up to date.

@RachelRVasquez RachelRVasquez removed their assignment Sep 23, 2016
@fuhton
Copy link
Contributor

fuhton commented Sep 27, 2016

Let's talk about this some more @RachelRVasquez I'm curious what your solution is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants