Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design system JS includes jQuery #395

Open
noahcooper opened this issue Jan 12, 2017 · 0 comments
Open

design system JS includes jQuery #395

noahcooper opened this issue Jan 12, 2017 · 0 comments

Comments

@noahcooper
Copy link

In Luminate Online, we already include jQuery separately from the design system. After jQuery is included, we use $.noConflict() to release $, since there are a handful of places where we still use prototype.js. Including jQuery in the design system gives $ back to jQuery, breaking anything that uses prototype.js.

Can we either remove jQuery from the design system and have it be included separately?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant