Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using PROCSOFT keyword instead of SOFTWARE #96

Open
buthanoid opened this issue Mar 3, 2022 · 4 comments
Open

Using PROCSOFT keyword instead of SOFTWARE #96

buthanoid opened this issue Mar 3, 2022 · 4 comments

Comments

@buthanoid
Copy link
Member

buthanoid commented Mar 3, 2022

On OI-Interface repository, the issue JMMC-OpenDev/OI-Imaging-JRA#10 have reached an agreement to use the PROCSOFT keyword to store the software used.

Note that the value will contain the name of the software followed by the version used.

I think the SOFTWARE keyword should be kept in the mechanism trying to detect the software (triggered when PROCSOFT is not correctly filled), for backward compatibility.
All mechanisms should keep working even if the version is not filled.

Note:
I did not find information about value specifications for PROCSOFT keyword from ESO. I only found examples which were in the form "somename_v_2_0" for example.
So I assumed these rules for the value of PROCSOFT understood by OImaging:

  • it must start with the name of the software
  • it can be lower case, upper case, mixed case (MiRA): it is not relevant
  • it can be followed by anything, i.e a version number in some format. OImaging does not parse anything more than the software name (for the moment). If version number should be parsed, some stricter rule would be good.

Note:
The "local" mode is not known in the PROCSOFT keyword. So currently, "Run More Iterations" button will never call local mode software.

@FerreolS
Copy link
Member

MiRA and SPARCO share the same PROCSOFT keyword (written by mira). This has to be fixed within mira:
see emmt/MiRA#16

@gmella
Copy link
Member

gmella commented Apr 4, 2022

@GillesDuvert , please try to use WISARD_CI_VERSION env var defined in Dockerfile

@GillesDuvert
Copy link

done

@FerreolS FerreolS removed this from the Exeter milestone Apr 6, 2022
@buthanoid
Copy link
Member Author

emmt/MiRA#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants