Fix ISSN fetcher

[ThiloteE]

JabRef version

6.0-alpha

Operating system

Windows

Details on version and operating system

No response

Checked with the latest development build (copy version output from About dialog)

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

How to reproduce:

Follow what is described in the forum: https://discourse.jabref.org/t/issn-fetch-noch-working/5346. In short: Add an ISSN to the entry and then fetch metadata.

Example ISSN:

1872-7980

Error:

Error occurred javax.net.ssl.SSLHandshakeException: (certificate_unknown) PKIX path validation failed: java.security.cert.CertPathValidatorException: validity check failed

Additional notes:

ISSN fetching was introduced in #10178.

Appendix

No response

[ThiloteE]

DOAJ has switched their API in June 2024. Maybe it broke ISSN fetching? Here are the docs to the current API (v.4.0.0): https://doaj.org/api/docs

[priyanshu16095]

I am interested in working on this. Please assign me this issue.
/assign-me

[priyanshu16095]

In my system, fetching data using a DOI is also resulting in an error.

[koppor]

In my system, fetching data using a DOI is also resulting in an error.

Which DOI did you provide?

[koppor]

@ThiloteE Was there any exception on the log? I am interested which server was used.

[priyanshu16095]

https://drive.google.com/file/d/1r38QUJmH9YpruwpiDSbXUXul3sBaW2Ar/view?usp=sharing
This happened.

[ThiloteE]

This issue is about ISSN and not an issue about DOI.

@priyanshu16095 If you have an issue with DOI, please open a new issue and while videos are great, it is nice to provide error messages in text so that developers can use it to search for relevant code in their IDE. It is also nice being able select and then to copy and paste complicated text instead having to manually type it off a video screen.

@koppor yes, there was an exception in the logs. Here it is:

Error while fetching bibliographic information
kong.unirest.core.UnirestException: javax.net.ssl.SSLHandshakeException: (certificate_unknown) PKIX path validation failed: java.security.cert.CertPathValidatorException: validity check failed
	at [email protected]/kong.unirest.core.DefaultInterceptor.onFail(Unknown Source)
	at [email protected]/kong.unirest.core.CompoundInterceptor.lambda$onFail$2(Unknown Source)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown Source)
	at java.base/java.util.Collections$2.tryAdvance(Unknown Source)
	at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(Unknown Source)
	at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(Unknown Source)
	at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
	at java.base/java.util.stream.FindOps$FindOp.evaluateSequential(Unknown Source)
	at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
	at java.base/java.util.stream.ReferencePipeline.findFirst(Unknown Source)
	at [email protected]/kong.unirest.core.CompoundInterceptor.onFail(Unknown Source)
	at [email protected]/kong.unirest.core.java.JavaClient.request(Unknown Source)
	at [email protected]/kong.unirest.core.BaseRequest.request(Unknown Source)
	at [email protected]/kong.unirest.core.BaseRequest.asJson(Unknown Source)
	at [email protected]/org.jabref.logic.importer.fetcher.JournalInformationFetcher.getJournalInformation(Unknown Source)
	at [email protected]/org.jabref.logic.importer.fetcher.IssnFetcher.performSearchById(Unknown Source)
	at [email protected]/org.jabref.gui.mergeentries.FetchAndMergeEntry.lambda$fetchAndMerge$0(Unknown Source)
	at [email protected]/org.jabref.logic.util.BackgroundTask$1.call(Unknown Source)
	at [email protected]/org.jabref.gui.util.UiTaskExecutor$1.call(Unknown Source)
	at [email protected]/javafx.concurrent.Task$TaskCallable.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
Caused by: javax.net.ssl.SSLHandshakeException: (certificate_unknown) PKIX path validation failed: java.security.cert.CertPathValidatorException: validity check failed
	at java.net.http/jdk.internal.net.http.HttpClientImpl.send(Unknown Source)
	at java.net.http/jdk.internal.net.http.HttpClientFacade.send(Unknown Source)
	... 15 more
Caused by: javax.net.ssl.SSLHandshakeException: (certificate_unknown) PKIX path validation failed: java.security.cert.CertPathValidatorException: validity check failed
	at java.base/sun.security.ssl.Alert.createSSLException(Unknown Source)
	at java.base/sun.security.ssl.TransportContext.fatal(Unknown Source)
	at java.base/sun.security.ssl.TransportContext.fatal(Unknown Source)
	at java.base/sun.security.ssl.TransportContext.fatal(Unknown Source)
	at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.checkServerCerts(Unknown Source)
	at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.onConsumeCertificate(Unknown Source)
	at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.consume(Unknown Source)
	at java.base/sun.security.ssl.SSLHandshake.consume(Unknown Source)
	at java.base/sun.security.ssl.HandshakeContext.dispatch(Unknown Source)
	at java.base/sun.security.ssl.SSLEngineImpl$DelegatedTask$DelegatedAction.run(Unknown Source)
	at java.base/sun.security.ssl.SSLEngineImpl$DelegatedTask$DelegatedAction.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/sun.security.ssl.SSLEngineImpl$DelegatedTask.run(Unknown Source)
	at java.base/java.util.ArrayList.forEach(Unknown Source)
	at java.net.http/jdk.internal.net.http.common.SSLFlowDelegate.lambda$executeTasks$3(Unknown Source)
	at java.net.http/jdk.internal.net.http.HttpClientImpl$DelegatingExecutor.execute(Unknown Source)
	at java.net.http/jdk.internal.net.http.common.SSLFlowDelegate.executeTasks(Unknown Source)
	at java.net.http/jdk.internal.net.http.common.SSLFlowDelegate.doHandshake(Unknown Source)
	at java.net.http/jdk.internal.net.http.common.SSLFlowDelegate$Reader.processData(Unknown Source)
	at java.net.http/jdk.internal.net.http.common.SSLFlowDelegate$Reader$ReaderDownstreamPusher.run(Unknown Source)
	at java.net.http/jdk.internal.net.http.common.SequentialScheduler$LockingRestartableTask.run(Unknown Source)
	at java.net.http/jdk.internal.net.http.common.SequentialScheduler$CompleteRestartableTask.run(Unknown Source)
	at java.net.http/jdk.internal.net.http.common.SequentialScheduler$SchedulableTask.run(Unknown Source)
	... 3 more
Caused by: sun.security.validator.ValidatorException: PKIX path validation failed: java.security.cert.CertPathValidatorException: validity check failed
	at java.base/sun.security.validator.PKIXValidator.doValidate(Unknown Source)
	at java.base/sun.security.validator.PKIXValidator.engineValidate(Unknown Source)
	at java.base/sun.security.validator.Validator.validate(Unknown Source)
	at java.base/sun.security.ssl.X509TrustManagerImpl.checkTrusted(Unknown Source)
	at java.base/sun.security.ssl.X509TrustManagerImpl.checkServerTrusted(Unknown Source)
	at [email protected]/org.jabref.logic.net.ssl.TrustStoreManager$1.checkServerTrusted(Unknown Source)
	at java.base/sun.security.ssl.AbstractTrustManagerWrapper.checkServerTrusted(Unknown Source)
	... 22 more
Caused by: java.security.cert.CertPathValidatorException: validity check failed
	at java.base/sun.security.provider.certpath.PKIXMasterCertPathValidator.validate(Unknown Source)
	at java.base/sun.security.provider.certpath.PKIXCertPathValidator.validate(Unknown Source)
	at java.base/sun.security.provider.certpath.PKIXCertPathValidator.validate(Unknown Source)
	at java.base/sun.security.provider.certpath.PKIXCertPathValidator.engineValidate(Unknown Source)
	at java.base/java.security.cert.CertPathValidator.validate(Unknown Source)
	... 29 more
Caused by: java.security.cert.CertificateExpiredException: NotAfter: Mon Dec 23 00:59:59 CET 2024
	at java.base/sun.security.x509.CertificateValidity.valid(Unknown Source)
	at java.base/sun.security.x509.X509CertImpl.checkValidity(Unknown Source)
	at java.base/sun.security.provider.certpath.BasicChecker.verifyValidity(Unknown Source)
	at java.base/sun.security.provider.certpath.BasicChecker.check(Unknown Source)
	... 34 more

[priyanshu16095]

@ThiloteE Sure, I'll remember next time.

[Siedlerchr]

at [email protected]/org.jabref.logic.importer.fetcher.JournalInformationFetcher.getJournalInformation(Unknown Source) 

This uses the api from jabref and I see that there is an invalid ssl cert https://jabref.org/api
=> This is a maintainer only issue