Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display rect incorrectly positioned and controls hidden behind loaded SVG #118

Open
nuvious opened this issue Dec 22, 2024 · 0 comments
Open

Comments

@nuvious
Copy link

nuvious commented Dec 22, 2024

PR to follow! This is an issue with a proposed solution incoming!

When loading an SVG, the exterior bounding box renders over the controls, sometimes making the start button unusable as well as other controls:

image

This seems to be a minor typo where the fullRect's y value was being assigned the x value of the svg. After correcting the css needed a minor adjustment to move the rectangle below the controls.

When testing locally after the above fix I also observed the below where the configuration would render below the svg, making some buttons and values inaccessible if the SVG was already fairly packed. I also observed this on the official demo:

image

However, this was corrected in the local environment by moving the controls div below the select div:

image

PR to follow with my proposed changes. Direction on correcting my changes welcome as I'm not primarily a javascript/html/css developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant