Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component inside Popout cannot use findDomNode #23

Open
mikemorton opened this issue Jun 24, 2016 · 2 comments
Open

Component inside Popout cannot use findDomNode #23

mikemorton opened this issue Jun 24, 2016 · 2 comments

Comments

@mikemorton
Copy link
Contributor

I've got a couple components that are wrapping legacy non-react modules. These components rely on findDomNode to work correctly, however if they're rendered inside the Popout they break down. Using refs also breaks down in this context. Does anyone have any ideas to get around this?

@rbardini
Copy link

rbardini commented Aug 16, 2016

I'm also having invariant violations due to refs:

Uncaught Invariant Violation: addComponentAsRefTo(...): Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component's render method, or you have multiple copies of React loaded (details: https://fb.me/react-refs-must-have-owner).

It was working before. I'm not sure if it started happening after upgrading React or the react-popout dependency.

EDIT: it looks like a [email protected] regression, as I couldn't reproduce the issue with 0.4.0.

@marchaos
Copy link
Collaborator

Can you retest with the latest version? I suspect this might have something to do with ReactDOM.findDomNode using the parent window object. I doubt it is fixed in the latest version, but I can investigate if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants