Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: exceptions when alignment fails #43

Open
krokicki opened this issue May 3, 2024 · 1 comment
Open

Feature request: exceptions when alignment fails #43

krokicki opened this issue May 3, 2024 · 1 comment

Comments

@krokicki
Copy link
Member

krokicki commented May 3, 2024

When insufficient moving spots are found, currently the issue is logged and the identity matrix is returned. It would be nice to throw an exception in this and other exceptional cases.

@GFleishman
Copy link
Member

Hi @krokicki and @cgoina!

I have added this feature to the master branch. There are three relevant commits.
Here I update the docstring to describe the new functionality: 6afdb8b
Here I update the code so that failed safeguards now raise a ValueError: 0930479
Here I make sure that this behavior is turned off in the distributed context (where we want warnings and defaults instead of exceptions): d81ad7b

I'll wait a bit before closing the thread in case either of you want to look at the update or comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants