EICrecon with LSan reports memory leaks in JStreamLog and JStreamLogBuffer

[wdconinc]

Ref. eic/EICrecon#1628

=================================================================
==609==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 272 byte(s) in 2 object(s) allocated from:
    #0 0x55e2fb0ba20d in operator new(unsigned long) (/home/runner/work/EICrecon/EICrecon/install/bin/eicrecon+0x10e20d) (BuildId: a5040da1707e76901d07b3ade4bdca35b7daccf2)
    #1 0x7f2d2a6a06d1 in JStreamLog::JStreamLog(std::ostream const&, char const*) (/opt/local/lib/libJANA.so+0x15d6d1) (BuildId: 7ee8b20a986d2d231d4fb255c9a0cd83b13e422c)

Indirect leak of 21 byte(s) in 2 object(s) allocated from:
    #0 0x55e2fb0ba31d in operator new[](unsigned long) (/home/runner/work/EICrecon/EICrecon/install/bin/eicrecon+0x10e31d) (BuildId: a5040da1707e76901d07b3ade4bdca35b7daccf2)
    #1 0x7f2d2a6a13dd in JStreamLogBuffer::JStreamLogBuffer(std::basic_streambuf<char, std::char_traits<char>>*, char const*) (/opt/local/lib/libJANA.so+0x15e3dd) (BuildId: 7ee8b20a986d2d231d4fb255c9a0cd83b13e422c)

This started to happen around https://eicweb.phy.anl.gov/containers/eic_container/-/commit/66c92d16d00475a373967f6727b71127472fd083, i.e. the jana2 v2.3.1 to v2.3.2 upgrade.

This could be caused by the news in the following two places:

• JANA2/src/libraries/JANA/Compatibility/JStreamLog.cc

  Line 14 in 38c0e9a

  JStreamLog::JStreamLog(const std::ostream& os, const char* tag) : std::ostream(new JStreamLogBuffer(os.rdbuf(), tag)), own_rdbuf(true)

• JANA2/src/libraries/JANA/Compatibility/JStreamLogBuffer.cc

  Line 22 in 38c0e9a

  __tag(strcpy(new char[strlen(tag)+1], tag)),

@nathanwbrei Tagging you here as well.