Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seg fault on wrong-type in python config #149

Open
tomeichlersmith opened this issue Jun 8, 2022 · 1 comment
Open

seg fault on wrong-type in python config #149

tomeichlersmith opened this issue Jun 8, 2022 · 1 comment

Comments

@tomeichlersmith
Copy link
Collaborator

When using an old python config which accidentally had p.input_files be [['file.root']] instead of ['file.root'], I got a seg fault during initial running and translating of the python configuration. This could be avoided by improving the translating procedure. There are a few different levels of fixes I could implement.

  1. Include more PyCheck calls within the current ConfigurePython to make sure the inputs are the correct type.
  2. Rework ConfigurePython so that the translation will work even if the wrong type is used. Types would then be flagged as wrong during getParameter calls. (This is what ldmx-sw Framework does)
  3. (in addition to either of the above options) Introduce a base python configuration class which requires a type definition for all class members. This is more of a seismic redesign which would enforce a rewrite of the current config scripts.
@tomeichlersmith
Copy link
Collaborator Author

@cbravo135 Can I require C++17? devtoolset-8 has a C++17 enabled compiler and this would allow me to use std::any making the implementation of a variadic ParameterSet class much simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant