You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using an old python config which accidentally had p.input_files be [['file.root']] instead of ['file.root'], I got a seg fault during initial running and translating of the python configuration. This could be avoided by improving the translating procedure. There are a few different levels of fixes I could implement.
Include more PyCheck calls within the current ConfigurePython to make sure the inputs are the correct type.
Rework ConfigurePython so that the translation will work even if the wrong type is used. Types would then be flagged as wrong during getParameter calls. (This is what ldmx-sw Framework does)
(in addition to either of the above options) Introduce a base python configuration class which requires a type definition for all class members. This is more of a seismic redesign which would enforce a rewrite of the current config scripts.
The text was updated successfully, but these errors were encountered:
@cbravo135 Can I require C++17? devtoolset-8 has a C++17 enabled compiler and this would allow me to use std::any making the implementation of a variadic ParameterSet class much simpler.
When using an old python config which accidentally had
p.input_files
be[['file.root']]
instead of['file.root']
, I got a seg fault during initial running and translating of the python configuration. This could be avoided by improving the translating procedure. There are a few different levels of fixes I could implement.PyCheck
calls within the currentConfigurePython
to make sure the inputs are the correct type.ConfigurePython
so that the translation will work even if the wrong type is used. Types would then be flagged as wrong duringgetParameter
calls. (This is what ldmx-sw Framework does)The text was updated successfully, but these errors were encountered: