Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beam energy is assumed to be 10.6 everywhere #131

Closed
c-dilks opened this issue Mar 12, 2024 · 3 comments · Fixed by #256
Closed

Beam energy is assumed to be 10.6 everywhere #131

c-dilks opened this issue Mar 12, 2024 · 3 comments · Fixed by #256
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@c-dilks
Copy link
Member

c-dilks commented Mar 12, 2024

Look it up via RCDB (or CCDB, if we decide to add the "corrected" beam energy there)

@c-dilks c-dilks pinned this issue Apr 2, 2024
@c-dilks c-dilks added bug Something isn't working help wanted Extra attention is needed labels Apr 12, 2024
@dglazier
Copy link
Contributor

In the first instance you should probably just have a SetBeamEnergy function which propogates to the algorithms (probably in ChangeRun), with the users responsible for calling. Most/all analyses should have a method of getting the beam energy and it should not necessarily be iguana's job.

@c-dilks
Copy link
Member Author

c-dilks commented May 21, 2024

Most/all analyses should have a method of getting the beam energy and it should not necessarily be iguana's job.

The tests will need to know the beam energy, however, or at least assume a default. Perhaps we can restrict Iguana's usage of CCDB and RCDB to the tests, but we may eventually have algorithms that are reliant on CCDB and RCDB.

@dglazier
Copy link
Contributor

Perhaps we should do the opposite then and consider if iguana can interface to the dbs as part of its scope. I would be quite happy removing it from clas12root ! And probably it will need database access.

@c-dilks c-dilks linked a pull request Aug 5, 2024 that will close this issue
@c-dilks c-dilks self-assigned this Aug 5, 2024
@c-dilks c-dilks unpinned this issue Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants