Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTBased EventBuilderFilter #202

Open
dglazier opened this issue May 11, 2024 · 4 comments
Open

FTBased EventBuilderFilter #202

dglazier opened this issue May 11, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@dglazier
Copy link
Contributor

Need an option, or a separate filter to work on FTBased PID from RECFT::Particle::pid
If no FT particle exists, should default to REC::Particle for that event.

@c-dilks c-dilks added the enhancement New feature or request label May 12, 2024
@c-dilks
Copy link
Member

c-dilks commented May 29, 2024

FTEnergyCorrection and its validator will also need this sort of feature

@dglazier
Copy link
Contributor Author

Not sure about that. FTEnergyCorrection should apply to any charged particle in the FT. The FTBased pid does not effect that.

@c-dilks
Copy link
Member

c-dilks commented May 29, 2024

According to @asligonulacar the FTEnergyCorrection should support REC::Particle as well; at the moment it requires RECFT::Particle. Since this issue is similar to that of EventBuilderFilter, we might as well handle both of them in one PR.

@dglazier
Copy link
Contributor Author

Yes it should change both. Although if someone is using an electron in the FT and not using FT based, it is likely they are doing something wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants