Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithim scope #224

Open
dglazier opened this issue May 24, 2024 · 1 comment
Open

Algorithim scope #224

dglazier opened this issue May 24, 2024 · 1 comment
Labels
question Further information is requested

Comments

@dglazier
Copy link
Contributor

What is planned for algorithms which have different behaviour in different detector regions. For example we now have MomentumCorrection and FTEnergyCorrection, which are both momentum corrections, but apply in different places. Similarly we should get CD corrections. When using actions we are assumed to know which correction to apply. Is this the planned behaviour, or will we plan to also supply the region to the action and let it find the correction ? At the moment I am planning to add this behaviour to clas12root anyway so the user does not have to choose. Probably when using Run it does this automatically. If it is planned to keep things as they are, which is fine with me, we might want to have a standardised naming scheme, i.e. FDMomentumCorrection and FTMomentumCorrection.

@dglazier dglazier added the question Further information is requested label May 24, 2024
@c-dilks
Copy link
Member

c-dilks commented May 24, 2024

I think a naming scheme would be good, and it should be introduced soon, since renaming things is a breaking change (unless we somehow map old names to new names internally...). An alternative is changing their namespaces, e.g. clas12::FD::MomentumCorrections.

At the very least, the algorithms' documentation needs to be clear about the algorithm domains.

What other categorizations beyond {FT,FD,CD} would be useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: Todo
Development

No branches or pull requests

2 participants