Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binding for SkCanvas::getSurface() #593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcpiroman
Copy link
Contributor

https://api.skia.org/classSkCanvas.html#aa55c3571746344d0887ed56abd2f9973

Btw is there some conversion tool? Or was it all done with rewrite/regex?

@igordmn igordmn self-requested a review September 16, 2022 18:40
Copy link
Collaborator

@igordmn igordmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

*
* @return the surface this canvas is owned by, or null if it is not owned by any surface.
*/
val surface: Surface?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a simple test to CanvasTest?

@igordmn
Copy link
Collaborator

igordmn commented Sep 21, 2022

Btw is there some conversion tool? Or was it all done with rewrite

No, it was written with ultra modern copy-paste technique :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants