Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #768: Permit creating arbitrary color spaces #770

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LoadingByte
Copy link
Contributor

This changeset implements the ideas from issue #768.

While working on this, I realized that the method ColorSpace::convert does not function as you would expect, since it completely disregards the gamut. I presume that some client depends on this method, so I haven't touched it, but added a comment that warns about its behavior.

If you'd like me to change anything, be it API-wise, style-wise, or anything really, feel free to point it out.

@LoadingByte
Copy link
Contributor Author

LoadingByte commented Jul 25, 2023

Thanks for running it on the CI! The build failures were kind of expected as I did not manage to test the C++ code under nativeJsMain/ locally. I'll try to fix the errors.

@LoadingByte
Copy link
Contributor Author

I believe all errors are fixed now. It would be amazing if someone could re-run the workflow to see whether the tests now pass on all platforms.

@dima-avdeev-jb dima-avdeev-jb requested review from dima-avdeev-jb and removed request for dima-avdeev-jb August 1, 2023 10:43
@dima-avdeev-jb
Copy link
Contributor

Thanks for PR! We will need some time to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants