CorePatch not fully functional on some devices #32

Keeperorowner · 2024-09-15T07:31:55Z

Steps to reproduce/复现步骤

Install CorePatch, enable functions, restart, and install applications with different signatures

Expected behaviour/预期行为

Disabling the apk signature verification function takes effect

Actual behaviour/实际行为

Disable The apk signature verification function is disabled

Xposed Module List/Xposed 模块列表

rezygisk

Magisk Module List/Magisk 模块列表

zygisk_lsposed

LSPosed version/LSPosed 版本

1.10.0

Android version/Android 版本

14

Magisk version/Magisk 版本

Apatch

Riru version/Riru 版本

N/A

Version requirement/版本要求

I am using latest debug CI version of LSPosed and enable verbose log/我正在使用最新 CI 调试版本且启用详细日志

Logs/日志

All modules use the debug version, but there are no useful logs either，If anyone else has this bug, please post your log，I can basically confirm that it is the problem of this lsposed framework, because I will not have this problem when I use the official version and other modified versions.Maybe it's because I'm using the Apatch instead of magisk

JingMatrix · 2024-09-15T08:08:48Z

By the way, if you try the version in GitHub Release, will CorePatch fully function?

Keeperorowner · 2024-09-15T13:43:41Z

Disabling the apk signature verification function using the release version also does not take effect

JingMatrix · 2024-09-15T17:11:18Z

@Keeperorowner Are you sure? I meant the version donwloaded from https://github.com/JingMatrix/LSPosed/releases/tag/v1.10.0

Keeperorowner · 2024-09-15T17:24:51Z

@Keeperorowner Are you sure? I meant the version donwloaded from https://github.com/JingMatrix/LSPosed/releases/tag/v1.10.0

I misunderstood what you meant earlier, but I have just tested with your Release version and found that the problem still exists and applications with different signatures still cannot override the installation😭😭

Keeperorowner · 2024-09-15T17:26:06Z

@Keeperorowner Are you sure? I meant the version donwloaded from https://github.com/JingMatrix/LSPosed/releases/tag/v1.10.0

Do you still need me to provide a log

JingMatrix · 2024-09-15T18:15:09Z

found that the problem still exists and applications with different signatures still cannot override the installation😭😭

That shouldn't be, beacuse this version is basically the same with most popular forks.

It was a relase version, so logs are less information. But anyway, please upload one (who knows ?).

Keeperorowner · 2024-09-16T01:35:42Z

found that the problem still exists and applications with different signatures still cannot override the installation😭😭

That shouldn't be, beacuse this version is basically the same with most popular forks.

It was a relase version, so logs are less information. But anyway, please upload one (who knows ?).

LSPosed_2024-09-16T09_34_30.346585.zip
by my real device

Keeperorowner · 2024-09-16T01:41:10Z

found that the problem still exists and applications with different signatures still cannot override the installation😭😭

That shouldn't be, beacuse this version is basically the same with most popular forks.

It was a relase version, so logs are less information. But anyway, please upload one (who knows ?).

I just used my Android 9 virtual machine to test, using Alpha mask, previously using the official version of lsposed, the core path is working, just now I installed your release version of lsposed, found that the core path function is also not working

Keeperorowner · 2024-09-16T01:42:21Z

Here's a copy of the virtual machine, Android 9 log
LSPosed_2024-09-16T01_23_35.633.zip

JingMatrix · 2024-09-16T04:07:08Z

Aha, this time the log is relevant and tells where the problem is. Interesting.

JingMatrix · 2024-09-16T04:30:19Z

Your OnePlus device is Android 14, but in the logs of 2024-09-16T09:07:25.066171,

[ 2024-09-16T09:16:19.970    10644: 10065: 10065 I/Magisk          ] Magisk 6066b5cf(25200) daemon started
[ 2024-09-16T09:16:19.971    10644: 10065: 10065 E/Magisk          ] open: /sys/fs/cgroup/cgroup.procs failed with 13: Permission denied
[ 2024-09-16T09:16:19.972    10644: 10065: 10065 D/Magisk          ] resetprop: prop [ro.config.per_app_memcg] does not exist
[ 2024-09-16T09:16:19.972    10644: 10065: 10065 E/Magisk          ] open: /dev/memcg/apps/cgroup.procs failed with 13: Permission denied
[ 2024-09-16T09:16:19.972    10644: 10065: 10065 I/Magisk          ] * Device API level: 28
[ 2024-09-16T09:16:19.985    10644: 10065: 10068 D/Magisk          ] resetprop: getprop [ro.crypto.state]: [unsupported]
[ 2024-09-16T09:16:19.985    10644: 10065: 10068 I/Magisk          ] ** post-fs-data mode running
[ 2024-09-16T09:16:19.985    10644: 10065: 10068 E/Magisk          ] opendir: /dev/block failed with 13: Permission denied

It is reported by Magisk that you are using Android 9 (Device API level: 28), which causes the failure of CorePatch.

Please update your Magisk or disable some related modules that "change" the API level.

Keeperorowner · 2024-09-16T05:15:51Z

This appears to be the content of my virtual machine log, and I can't seem to change the built-in magisk version of the virtual machine

Keeperorowner · 2024-09-16T05:17:29Z

And the core path should be adapted to Android 9 to Android 15, it should not fail🤔

JingMatrix · 2024-09-16T05:57:09Z

Then please upload the log from your devices with the GitHub Release version.

I don't think that your virtual machine could prentend to be a OnePlus/PJE110.

Keeperorowner · 2024-09-16T08:17:15Z

Then please upload the log from your devices with the GitHub Release version.

I don't think that your virtual machine could prentend to be a OnePlus/PJE110.

Then you can take a look at my real machine log
LSPosed_2024-09-16T16_11_02.585001.zip

Keeperorowner · 2024-09-16T08:22:06Z

I just submitted the issue under the core path and asked them to check the problem as well，Maybe it's a compatibility issue with the module itself

JingMatrix · 2024-09-16T11:19:21Z

This is the related part of CorePatch crash:

java.lang.ClassNotFoundException: Didn't find class "android.content.pm.PackageParser.PackageParserException" on path: DexPathList[[zip file "/system/framework/com.android.location.provider.jar", zip file "/system/framework/services.jar", zip file "/system/framework/oplus-services.jar", zip file "/system/framework/oplus-service-jobscheduler.jar", zip file "/apex/com.android.adservices/javalib/service-adservices.jar", zip file "/apex/com.android.adservices/javalib/service-sdksandbox.jar", zip file "/apex/com.android.appsearch/javalib/service-appsearch.jar", zip file "/apex/com.android.art/javalib/service-art.jar", zip file "/apex/com.android.configinfrastructure/javalib/service-configinfrastructure.jar", zip file "/apex/com.android.healthfitness/javalib/service-healthfitness.jar", zip file "/apex/com.android.media/javalib/service-media-s.jar", zip file "/apex/com.android.ondevicepersonalization/javalib/service-ondevicepersonalization.jar", zip file "/apex/com.android.permission/javalib/service-permission.jar", zip file "/apex/com.android.rkpd/javalib/service-rkp.jar"],nativeLibraryDirectories=[/system/lib64, /system_ext/lib64, /system/lib64, /system_ext/lib64]]

Please use the debug version of CorePatch and upload logs again.

happypotter321 · 2024-09-16T12:10:36Z

Same issue here, on android 13. Tried with magisk alpha, kitsune mask, the original magisk latest stable release. Corepatch works fine with lposedmod 1.9.3. I'll try to post a log later.

happypotter321 · 2024-09-16T12:49:42Z

LSPosed_2024-09-16T18_17_06.698778.zip

Keeperorowner · 2024-09-16T14:12:37Z

This is the related part of CorePatch crash:

java.lang.ClassNotFoundException: Didn't find class "android.content.pm.PackageParser.PackageParserException" on path: DexPathList[[zip file "/system/framework/com.android.location.provider.jar", zip file "/system/framework/services.jar", zip file "/system/framework/oplus-services.jar", zip file "/system/framework/oplus-service-jobscheduler.jar", zip file "/apex/com.android.adservices/javalib/service-adservices.jar", zip file "/apex/com.android.adservices/javalib/service-sdksandbox.jar", zip file "/apex/com.android.appsearch/javalib/service-appsearch.jar", zip file "/apex/com.android.art/javalib/service-art.jar", zip file "/apex/com.android.configinfrastructure/javalib/service-configinfrastructure.jar", zip file "/apex/com.android.healthfitness/javalib/service-healthfitness.jar", zip file "/apex/com.android.media/javalib/service-media-s.jar", zip file "/apex/com.android.ondevicepersonalization/javalib/service-ondevicepersonalization.jar", zip file "/apex/com.android.permission/javalib/service-permission.jar", zip file "/apex/com.android.rkpd/javalib/service-rkp.jar"],nativeLibraryDirectories=[/system/lib64, /system_ext/lib64, /system/lib64, /system_ext/lib64]]

Please use the debug version of CorePatch and upload logs again.

There are other people who have the same problem as me and also upload a log using the debug version
LSPosed_2024-09-16T22_11_15.168245.zip

JingMatrix · 2024-09-16T17:08:31Z

Could you please try the latest build: https://github.com/JingMatrix/LSPosed/actions/runs/10888090132 ?

In case this isn't fixed, please upload logs, thanks.

Keeperorowner · 2024-09-16T18:24:30Z

Could you please try the latest build: https://github.com/JingMatrix/LSPosed/actions/runs/10888090132 ?

In case this isn't fixed, please upload logs, thanks.

It doesn't seem to work.Attach the log
LSPosed_2024-09-17T02_23_25.621675.zip

JingMatrix · 2024-09-16T18:39:40Z

@Keeperorowner Could you please also try the release build of CI?
It is strange that the logs you updated was totally normal. Maybe a release version gives better relevant logs.

happypotter321 · 2024-09-16T22:59:30Z

Update:

So I tried the release build for lposed from the link you provided (7096) and that made downgrading applications possible with the release build of core patch. However, installing applications with different signatures, or applications with no signatures weren't possible. (both possible with lposed mod, but disable digest verify has to be enabled still for it to be possible to install applications with no signatures)

Enabling "Disable digest Verify" in Core Patch settings made it possible to install applications with no signatures, but installing apps with different signatures is still not possible even with any combination of the settings toggled in core patch (also tried enabling all the settings on it)

Here's the log with all the settings enabled in core patch. (nothing except for disable digest verify seemed to do anything though)
LSPosed_2024-09-17T04_07_57.496895.zip

happypotter321 · 2024-09-16T23:01:10Z

After that, I tried the Debug build from the link you provided (7096), and same issue. The logs looked a little bit different though, but I don't know what that means. No idea if this would help but here's the file.
Uploading LSPosed_2024-09-17T04_13_47.924748.zip…

Keeperorowner · 2024-09-17T01:57:22Z

@Keeperorowner Could you please also try the release build of CI?
It is strange that the logs you updated was totally normal. Maybe a release version gives better relevant logs.

Using the release version, the problem still exists, you look at the log
LSPosed_2024-09-17T09_52_15.220079.zip

privacyguy123 · 2024-09-18T09:54:30Z

I see an increasing number of people reporting this bug in the CorePatch Telegram, me included. Do you have any idea what would be causing a specific module not to work on your fork if your fork is based on the original Lsposed which reportedly this module works fine with?

JingMatrix · 2024-09-18T11:02:32Z

CorePatch always works well with JingMatrix/LSPosed on my device (Android 15) after my pull-request LSPosed/CorePatch#115 is merged, so I was ignorant of this issue.

After some relevant logs are uploaded, I figured out the problem was related to my changes of the apache module org.apache.commons.lang3. Hence, commit 558aa09 should have closed this issue.

From partial test results, it already worked for Android 9, 12 and 13 devices.
So if CorePatch still fails on your devices with the latest CI build of LSPosed, please then upload your logs to help this issue. Current known logs didn't help me to understand the cause yet.

privacyguy123 · 2024-09-18T11:08:33Z

I cannot install packages with different signatures currently - I see nothing in logs that would help debug this at all, there are no errors from CorePatch.

JingMatrix · 2024-09-18T11:19:47Z

Sorry, I made a mistake regarding the git commits. Some changed wasn't uploaded (due to some rebase error I guess).
Now I have fixed the commit e365baf.
Please try the latest CI build https://github.com/JingMatrix/LSPosed/actions/runs/10920996299, and tell me if everything works well.

happypotter321 · 2024-09-18T13:22:03Z

Still can't install apps with different signatures on the build you linked (7096) I tried the release version btw.
LSPosed_2024-09-18T18_44_11.701181.zip

JingMatrix · 2024-09-18T13:50:22Z

@happypotter321 Your log was not uploaded sucessfully. Could you please upload it again? You may need to wait it a bit when you attach logs while editing your comments.

happypotter321 · 2024-09-18T13:58:04Z

Done (edited the comment and re-uploaded the file) sorry about that, didn't know it was a thing.

JingMatrix · 2024-09-18T14:20:20Z

@happypotter321 Could you please record logs while you failed to install apps with different signature ?
Simply run:

adb logcat > full.log

And then upload full.log file.

happypotter321 · 2024-09-18T18:01:57Z

For privacy reasons, I decided to delete the entries before what can be seen here. This is the part from where the package manager seemed to have initiated and stuff (although at the top I guess it's just google play protect, I mean I disabled it so, but I included it just in case cause I'm not sure), after that nothing was edited. I hope that's okay, if not I can try to change some stuff on my device later and upload an unedited log. But yeah the stuff before seemed to be unrelated.

Somewhere around line 43 is where it happened I think.

full.log

Edit: didn't realize lposed log archive already contained a "full.log" oof.

JingMatrix · 2024-09-19T15:39:23Z

I have added more logs to CorePatch. Please install the debug version from here: https://github.com/JingMatrix/CorePatch/actions/runs/10944123171

For the settings of CorePatch, please only enable Disable compare signatures.
Note that you must restart your phone before testing CorePatch.

If CorePatch didn't work as expected, please attach your logs.

happypotter321 · 2024-09-19T17:20:49Z

So I did those just now, and the results were the same unfortunately.
LSPosed_2024-09-19T22_25_23.015352.zip

JingMatrix · 2024-09-19T18:23:05Z

@happypotter321 Sorry, I made a mistake about the instruction. I wanted to say that please enable only the Disable compare signatures option. Don't forget to restart you phone for a new test.
Thank you for continuing this test. Please upload logs if it doesn't work.

happypotter321 · 2024-09-19T19:46:27Z

No worries, thanks for still trying to sort it out. Same thing happened with just that setting enabled, and I rebooted before testing, here's the log.
LSPosed_2024-09-20T01_11_12.311707.zip

JingMatrix · 2024-09-19T21:26:30Z

@happypotter321 I have found a bit clue in your last logs. Please use the debug version of LSPosed from the latest CI and upload logs after CorePatch failed so that I may find more details.

happypotter321 · 2024-09-19T22:29:15Z

LSPosed_2024-09-20T03_39_20.382240.zip

This, right?

Edit: Nevermind, I used the one before the latest above. This one is the latest, but I'll include both just in case. I need to sleep.
LSPosed_2024-09-20T07_00_42.562340.zip

JingMatrix · 2024-09-20T11:22:45Z

@happypotter321 Thank you again for your participating. This is really a difficult issue.
Could you please use a debug version of some LSPosed that actually works for you and upload the logs (after you install an app with different signature sucessfully)?
I want to compare to see what could cause this problem.

happypotter321 · 2024-09-20T14:04:25Z

No problem. Well I couldn't download the debug versions of lposed mod, or the original lposed from github, but I managed to find a debug build of the original lposed (I think) on telegram, and it was possible to install apps with different signatures with only "disable compare signatures" enabled in core patch using that lposed version. Lposed mod worked too, the release build on github, but so far this was the only debug version I could download.

Here's the log
LSPosed_2024-09-20T19_05_29.686658.zip

Chen-hai-0721 · 2024-09-20T16:32:31Z

Very good, the latest version of ci construction, my device can use Corepath normally, thank you

JingMatrix · 2024-09-20T17:22:19Z

@Nimpip That latest is still working in progress. How about this one?
https://github.com/JingMatrix/LSPosed/actions/runs/10933177132

Chen-hai-0721 · 2024-09-20T17:33:17Z

I installed this version before, Corepath disable signature does not take effect，It should be the last few commits that have fixed the problem

pluseach · 2024-09-21T05:06:38Z

This version, the one you build locally works for me too:
#39 (comment), #39 (comment)

this one also doesn't work on me:
#39 (comment)

I'm on Taoyao Evo X, Android 14.. build by dkpost3.

It is confirmed that commits between 16c09ce and 75e3005 cause #32

privacyguy123 · 2024-09-22T09:38:11Z

Which build should I install to test? It seems Actions is just spitting out same 7096 build over and over.

Even if dladdr could not find function name for an address given by art_symbol_resolver, we should still process inline hook. Close #32 as completed, close #39 as merged

Keeperorowner added the bug Something isn't working label Sep 15, 2024

JingMatrix changed the title ~~The core path function of some devices does not take effect~~ CorePatch not fully functional on some devices Sep 15, 2024

JingMatrix added the question Further information is requested label Sep 15, 2024

Keeperorowner mentioned this issue Sep 16, 2024

在JingMatrix的mod框架，部分功能不生效 LSPosed/CorePatch#117

Closed

JingMatrix mentioned this issue Sep 20, 2024

[WIP] Find out the commits that failed CorePatch #39

Closed

JingMatrix linked a pull request Sep 20, 2024 that will close this issue

[WIP] Find out the commits that failed CorePatch #39

Closed

This comment was marked as outdated.

Sign in to view

JingMatrix added a commit that referenced this issue Sep 21, 2024

Keep inline hook to fix CorePatch issue

05dc4a7

It is confirmed that commits between 16c09ce and 75e3005 cause #32

JingMatrix added a commit that referenced this issue Sep 21, 2024

Keep inline hook to fix CorePatch issue

ad23736

It is confirmed that commits between 16c09ce and 75e3005 cause #32

JingMatrix closed this as completed in e50a3f3 Sep 22, 2024

JingMatrix added a commit that referenced this issue Oct 17, 2024

Fix Dobby hook fallback

c350b6a

Even if dladdr could not find function name for an address given by art_symbol_resolver, we should still process inline hook. Close #32 as completed, close #39 as merged

CorePatch not fully functional on some devices #32

CorePatch not fully functional on some devices #32

Comments

Keeperorowner commented Sep 15, 2024 • edited by JingMatrix Loading

Steps to reproduce/复现步骤

Expected behaviour/预期行为

Actual behaviour/实际行为

Xposed Module List/Xposed 模块列表

Magisk Module List/Magisk 模块列表

LSPosed version/LSPosed 版本

Android version/Android 版本

Magisk version/Magisk 版本

Riru version/Riru 版本

Version requirement/版本要求

Logs/日志

JingMatrix commented Sep 15, 2024

Keeperorowner commented Sep 15, 2024

JingMatrix commented Sep 15, 2024

Keeperorowner commented Sep 15, 2024

Keeperorowner commented Sep 15, 2024

JingMatrix commented Sep 15, 2024

Keeperorowner commented Sep 16, 2024 • edited Loading

Keeperorowner commented Sep 16, 2024

Keeperorowner commented Sep 16, 2024

JingMatrix commented Sep 16, 2024

JingMatrix commented Sep 16, 2024

Keeperorowner commented Sep 16, 2024

Keeperorowner commented Sep 16, 2024

JingMatrix commented Sep 16, 2024 • edited Loading

Keeperorowner commented Sep 16, 2024

Keeperorowner commented Sep 16, 2024 • edited Loading

JingMatrix commented Sep 16, 2024

happypotter321 commented Sep 16, 2024

happypotter321 commented Sep 16, 2024

Keeperorowner commented Sep 16, 2024

JingMatrix commented Sep 16, 2024

Keeperorowner commented Sep 16, 2024 • edited Loading

JingMatrix commented Sep 16, 2024

happypotter321 commented Sep 16, 2024

happypotter321 commented Sep 16, 2024

Keeperorowner commented Sep 17, 2024

privacyguy123 commented Sep 18, 2024

JingMatrix commented Sep 18, 2024

privacyguy123 commented Sep 18, 2024

JingMatrix commented Sep 18, 2024 • edited Loading

happypotter321 commented Sep 18, 2024 • edited Loading

JingMatrix commented Sep 18, 2024

happypotter321 commented Sep 18, 2024

JingMatrix commented Sep 18, 2024

happypotter321 commented Sep 18, 2024 • edited Loading

JingMatrix commented Sep 19, 2024 • edited Loading

happypotter321 commented Sep 19, 2024

JingMatrix commented Sep 19, 2024

happypotter321 commented Sep 19, 2024

JingMatrix commented Sep 19, 2024

happypotter321 commented Sep 19, 2024 • edited Loading

JingMatrix commented Sep 20, 2024

happypotter321 commented Sep 20, 2024

Chen-hai-0721 commented Sep 20, 2024

JingMatrix commented Sep 20, 2024

Chen-hai-0721 commented Sep 20, 2024 • edited Loading

This comment was marked as outdated.

pluseach commented Sep 21, 2024 • edited Loading

privacyguy123 commented Sep 22, 2024

Keeperorowner commented Sep 15, 2024 •

edited by JingMatrix

Loading

Keeperorowner commented Sep 16, 2024 •

edited

Loading

JingMatrix commented Sep 16, 2024 •

edited

Loading

Keeperorowner commented Sep 16, 2024 •

edited

Loading

Keeperorowner commented Sep 16, 2024 •

edited

Loading

JingMatrix commented Sep 18, 2024 •

edited

Loading

happypotter321 commented Sep 18, 2024 •

edited

Loading

happypotter321 commented Sep 18, 2024 •

edited

Loading

JingMatrix commented Sep 19, 2024 •

edited

Loading

happypotter321 commented Sep 19, 2024 •

edited

Loading

Chen-hai-0721 commented Sep 20, 2024 •

edited

Loading

pluseach commented Sep 21, 2024 •

edited

Loading