Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type definition file stopped working after 1.30.0 #658

Open
sweetboss12512 opened this issue Jun 26, 2024 · 1 comment · May be fixed by #745
Open

Type definition file stopped working after 1.30.0 #658

sweetboss12512 opened this issue Jun 26, 2024 · 1 comment · May be fixed by #745
Labels
bug Something isn't working

Comments

@sweetboss12512
Copy link

I updated the extension and my definitions file fails to read
it works again when i revert to 1.29.1
settings.json:

{
    "luau-lsp.sourcemap.enabled": false,
    "luau-lsp.platform.type": "roblox",
    "luau-lsp.types.definitionFiles": [
        "./build/pilot.d.lua"
    ],
}

definitions file:
pilot.d.lua
@JohnnyMorganz JohnnyMorganz added the bug Something isn't working label Jun 26, 2024
@JohnnyMorganz
Copy link
Owner

pilot.d.lua files reference Enum.Foo, which is a mutated type definition. We started deferring our "definitions mutations" to post initialisation, meaning the pilot.d.luau files don't have access to the mutations, causing them to error. This is a bug, thanks for the report!

@voidedWarranties voidedWarranties linked a pull request Aug 16, 2024 that will close this issue
Open
@flxwed flxwed mentioned this issue Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix loading type definitions that rely on mutation voidedWarranties/luau-lsp
2 participants
@JohnnyMorganz @sweetboss12512