Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a revision in tree view fails for commits with "propset" on "/" #640

Open
ThelloD opened this issue Jul 11, 2019 · 3 comments
Open

Comments

@ThelloD
Copy link

ThelloD commented Jul 11, 2019

  • VSCode Version: 1.26.1
  • OS Version: Debian 4.18.10
  • Extension Version: 1.54.3
  • System Language: EN
  • SVN Version: 1.10.4

Issue

Tree view of revisions fails to open for revision where properties have been changed on "/" with error message "Invalid _path".

Likewise, the extension can't handle property changes with the path "/" properly.

Steps to Reproduce

  1. Open command line on root level of the SVN repository (not in a subdirectory)
  2. command line: svn propset svn:ignore "ignore-me" .
  3. Commit (svn ci)
  4. open VSCode, go to Subversion extension (tree view)
  5. Try to unfold latest revision
  6. Unfolding fails with error message "Invalid _path"

SVN Output

Output is generated when opening the subversion view

[svn-test-co]$ svn log -r HEAD:1 --limit=50 --xml -v file:///path/to/test/svn/repo

Clicking on the unfold triangle does not produce any new output but triggers the error message.

Screenshots

svn-error

@JohnstonCode
Copy link
Owner

Not able to reproduce. @ThelloD this still an issue for you?

@JohnstonCode JohnstonCode closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2024
@ThelloD
Copy link
Author

ThelloD commented Mar 12, 2024

Sorry I didn't reply to your question back in 2019 @JohnstonCode, I must have missed it! (wow, what an old issue that came up again... 😄)

I just tried to reproduce the issue, and the behavior still remains the same:

usr@host:/tmp$ svnadmin create svn-dummy-test-REPO
usr@host:/tmp$ svn co file:///tmp/svn-dummy-test-REPO svn-dummy-test      
Checked out revision 0.
usr@host:/tmp$ cd svn-dummy-test
usr@host:/tmp/svn-dummy-test$ echo "Hello World" > test.txt   
usr@host:/tmp/svn-dummy-test$ svn add test.txt         
A         test.txt
usr@host:/tmp/svn-dummy-test$ svn ci -m "test"                                     
Adding         test.txt
Transmitting file data .done
Committing transaction...
Committed revision 1.
usr@host:/tmp/svn-dummy-test$ svn up          
Updating '.':
At revision 1.
usr@host:/tmp/svn-dummy-test$ svn propset svn:ignore "ignore-me" . 
property 'svn:ignore' set on '.'
usr@host:/tmp/svn-dummy-test$ svn ci -m "changed prop"            
Sending        .
Committing transaction...
Committed revision 2.            
usr@host:/tmp/svn-dummy-test$ svn log                 
------------------------------------------------------------------------
r2 | usr | 2024-03-12 14:07:56 +0100 (Tue, 12 Mar 2024) | 1 line

changed prop
------------------------------------------------------------------------
r1 | usr | 2024-03-12 14:07:28 +0100 (Tue, 12 Mar 2024) | 1 line

test
------------------------------------------------------------------------

usr@host:/tmp/svn-dummy-test$ code .           
usr@host:/tmp/svn-dummy-test$ 

In VS Code, the previous error message "Invalid _path" is displayed again, when trying to unfold the latest revision. (In the example above: r2)

grafik

The SVN extension was installed in VS Code just now, so the latest available version (v2.17.0) is being used:
grafik

The bug isn't that severe since it's rather a "cosmetic" issue and e.g. won't affect file integrity etc., but it's definitely still present.

@JohnstonCode JohnstonCode reopened this Mar 13, 2024
@JohnstonCode
Copy link
Owner

Thank you for the re-production steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants