Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Concur recipes in TPS #204

Open
milesfrain opened this issue Aug 8, 2020 · 2 comments
Open

Fix Concur recipes in TPS #204

milesfrain opened this issue Aug 8, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@milesfrain
Copy link
Collaborator

We're using div id="app" in index.html, but TPS doesn't have access to this file, so runWidgetInDom "app" can't find what it needs.

try

We probably need to use a similar launch strategy as the Halogen and React recipes (see #198)

Also might be good for Concur to log an error to the console if runWidgetInDom can't find the element.

@gcsolaroli and @ajnsit for suggestions

@milesfrain milesfrain added the bug Something isn't working label Aug 8, 2020
@ajnsit
Copy link

ajnsit commented Aug 8, 2020

Concur has runWidgetInSelector as well which can populate the widget directly in the body i.e. runWidgetInSelector "body". Is that enough?

@milesfrain
Copy link
Collaborator Author

That might be enough. Looks like we'll have to wait for the package set to incorporate runWidgetInSelector and then wait for TPS to incorporate the updated package set.

@milesfrain milesfrain changed the title Fix HelloConcur in TPS Fix Concur recipes in TPS Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants