Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better nix.shell setup via niv #218

Open
eviefp opened this issue Aug 20, 2020 · 6 comments
Open

Better nix.shell setup via niv #218

eviefp opened this issue Aug 20, 2020 · 6 comments
Labels
cookbook Issues related to this repo as a whole and not a recipe in particular

Comments

@eviefp
Copy link

eviefp commented Aug 20, 2020

The current nix setup is a bit awkward to use. Would anyone mind if I swapped it to use niv to grab easy-purescript-nix instead? niv is just a thin layer on top of fetchgit and it handles sha's automatically.

This should not mean any changes for the README or anything like that. The only change is in updating the dependency to easy-purescript-nix, by making it significantly easier.

@eviefp eviefp added the cookbook Issues related to this repo as a whole and not a recipe in particular label Aug 20, 2020
@milesfrain
Copy link
Collaborator

Pinging @danielstaleiny for input, who initially set this up in #144

@eviefp eviefp changed the title Nix setup Better nix.shell setup via niv Aug 20, 2020
@thomashoneyman
Copy link

I’m curious to see this because I have several projects using easy-purescript-nix I have to regularly update. Do you have an existing project somewhere using this?

@danielstaleiny
Copy link
Contributor

Initial idea was to make it easier for nixos/nix users to set up this project. One of the worry I had, that if I would pull the latest, we would get more up to date version of the purescript dependencies and it could not work, so I pinned it down based on the version the project was using. I don't know if the project is always up to date with purescript latest versions and if so I think your solution would be better, otherwise pinning is better. However this is not question for me, but it is for maintainers. I think they are not using the nix so making nix working is not priority for them.

I think they would welcome version where they don't have to update nix file, I am also up for that.

@danielstaleiny
Copy link
Contributor

@thomashoneyman There is also more home cooked scripted way of doing this. This awesome guy made this script update script and how he keeps metadata for each packages metadata for neovim for example

Take it as inspiration. :)

@JordanMartinez
Copy link
Owner

I think they are not using the nix so making nix working is not priority for them.

I'm not using nix mainly because I haven't invested the time to learn it yet. I started reading through the original thesis and stopped on page 66. It'll likely take me a few more weeks to get through the entire thing. So, a lot of this is simply over my head for the time being. I would like to support nix as it would make it trivial (I believe) to set up things besides PureScript (e.g. databases for purescript-selda), but I also realize that not all users would want to use it.

@eviefp
Copy link
Author

eviefp commented Aug 25, 2020

My plan would still be to pin the versions. Maybe we just need a checklist when updating the compiler version for example in package.json, to also update the nix file (or at least ping someone who's comfortable doing that; I can volunteer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cookbook Issues related to this repo as a whole and not a recipe in particular
Projects
None yet
Development

No branches or pull requests

5 participants