-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kill sigui and messageBus for good? #9
Comments
I think the types in messageBus.js are useful. The messageBus is used to communicate between the page and RSign |
JoshOrndorff
changed the title
Kill sigui and messageBus for good
Kill sigui and messageBus for good?
Dec 6, 2018
Oh, You mean it's called by the RSign extension, right? If so, this issue is probably ready to be closed, right? |
Not the function. But the types are used. I think.
…On Wed, Dec 5, 2018, 8:55 PM Joshy Orndorff ***@***.*** wrote:
You mean that messageBus function I linked is used? It doesn't look like
it's ever called.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJNys6APT0j1WRwZ96nZeEimZ2IR2fOks5u2IckgaJpZM4ZFpE_>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@dckc When you factored out RSign and all the sigui stuff, this one function remained https://github.com/JoshOrndorff/RChain-Status/blob/master/sigui/messageBus.js#L54
It looks like the only mentions of it elsewhere in the code are commented out.
This comment seems to be saying you might have future intent for that file, but I didn't fully understand it.
Should messageBus and that sigui folder stick around?
The text was updated successfully, but these errors were encountered: