Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill sigui and messageBus for good? #9

Open
JoshOrndorff opened this issue Dec 6, 2018 · 3 comments
Open

Kill sigui and messageBus for good? #9

JoshOrndorff opened this issue Dec 6, 2018 · 3 comments

Comments

@JoshOrndorff
Copy link
Owner

@dckc When you factored out RSign and all the sigui stuff, this one function remained https://github.com/JoshOrndorff/RChain-Status/blob/master/sigui/messageBus.js#L54

It looks like the only mentions of it elsewhere in the code are commented out.

This comment seems to be saying you might have future intent for that file, but I didn't fully understand it.

Should messageBus and that sigui folder stick around?

@dckc
Copy link
Contributor

dckc commented Dec 6, 2018

I think the types in messageBus.js are useful. The messageBus is used to communicate between the page and RSign

@JoshOrndorff JoshOrndorff changed the title Kill sigui and messageBus for good Kill sigui and messageBus for good? Dec 6, 2018
@JoshOrndorff
Copy link
Owner Author

JoshOrndorff commented Dec 6, 2018

You mean that messageBus function I linked is used? It doesn't look like it's ever called.

Oh, You mean it's called by the RSign extension, right? If so, this issue is probably ready to be closed, right?

@dckc
Copy link
Contributor

dckc commented Dec 6, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants