Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify check on minify tests on PR #479

Open
VirtualDiegox opened this issue Oct 10, 2022 · 0 comments
Open

Verify check on minify tests on PR #479

VirtualDiegox opened this issue Oct 10, 2022 · 0 comments
Labels
Bug Something isn't working properly Medium Priority Issues with middle priority. The fix may not be urgent but necessary for production. Plugins Issue related to a plugin

Comments

@VirtualDiegox
Copy link
Collaborator

Describe the bug / issue
When a PR is made, several checks are run in order to verify and ensure the integrity of the repo. One of this verify if the plugins were minified, but it is not working properly because the check pass even if the files were not minified with the scripts.

To Reproduce
Steps to reproduce the behavior:

  1. Make a PR with changes on JS or CSS files on plugins without run the minify scripts
  2. Check the job on github actions and verify if the check is passed
  3. See error

Expected behavior
When files were not minified, the check must fail.

Additional context
This only must affect if JS or CSS files are modified, it would be a good idea check/modify the minify scripts to ensure the expected behavior

@VirtualDiegox VirtualDiegox added Bug Something isn't working properly Plugins Issue related to a plugin Medium Priority Issues with middle priority. The fix may not be urgent but necessary for production. labels Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working properly Medium Priority Issues with middle priority. The fix may not be urgent but necessary for production. Plugins Issue related to a plugin
Projects
None yet
Development

No branches or pull requests

1 participant