add Dukes/MacDonald

[MatthewCaseres]

No description provided.

[codecov]

Codecov Report

Merging #128 (3fbdfd8) into master (1406f5c) will increase coverage by 0.65%.
The diff coverage is 100.00%.

❗ Current head 3fbdfd8 differs from pull request most recent head 130c1a4. Consider uploading reports for the commit 130c1a4 to get more accurate results

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   90.70%   91.35%   +0.65%     
==========================================
  Files           9       10       +1     
  Lines         398      428      +30     
==========================================
+ Hits          361      391      +30     
  Misses         37       37              

Impacted Files	Coverage Δ
src/MortalityTables.jl	100.00% <ø> (ø)
src/dukes_macdonald.jl	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[MatthewCaseres]

closes #127

[alecloudenback]

Looks good overall, a couple of things before merging:

• Needs docstrings
• Please remove the type annotations on the methods.
  • Restricting to Float64 prevents other rate types (e.g. Float32, or Duals used with automatic differentiation)
  • errors can be more local to where the inappropriate type is used

[MatthewCaseres]

should be ok now

[alecloudenback]

Thanks!