Compat bump for ResumableFunctions and a versionbump for release #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
=======================================
Coverage 91.40% 91.40%
=======================================
Files 5 5
Lines 221 221
=======================================
Hits 202 202
Misses 19 19 ☔ View full report in Codecov by Sentry. |
|
Seems fine to me but I am not very familiar with this codebase. I will wait to merge until the end of the week in case any more qualified maintainers wish to comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResumableFunctions 1.0.0 was released, now with proper support for variable scopes (previously it was breaking local scopes). I tested it locally and it runs with CCDReduction.jl, so providing a version bump here.
CCDReduction.jl is also used in the CI of ResumableFunctions to check for unintentional breaking changes. Having a new release of CCDReduction.jl would be valuable for our CI.