Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Benchmarkset fails silently, returns null #369

Open
MarkoMekapses opened this issue May 16, 2024 · 1 comment
Open

@Benchmarkset fails silently, returns null #369

MarkoMekapses opened this issue May 16, 2024 · 1 comment

Comments

@MarkoMekapses
Copy link

Sometimes when I use Benchmarkset with a for loop, it fails to return anything.... If there's a syntax problem I think I'd prefer that it throw an error so I can correct it, but it's returning nothing, not even an empty Benchmarkgroup.

suite4 = @benchmarkset "suite4" for i in [8, 16, 32] 
			@case "contrast1" contrast1=fast_glcm_contrast($p1)  setup=(p1=fast_glcm_p1(img2; levels=$i))
			@case "contrast2" contrast2=fast_glcm_contrast2($p2) setup=(p1=fast_glcm_p2(img2; levels=$i))
	end

I've tried it without the setup, but same thing.

Thanks,

@willow-ahrens
Copy link
Collaborator

I honestly think we should just deprecate the macro. I usually build the benchmarkgroups manually, it's clearer.

https://github.com/willow-ahrens/Finch.jl/blob/main/benchmark/benchmarks.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants