Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: EditorialBot testing #143

Closed
editorialbot opened this issue Mar 24, 2024 · 63 comments
Closed

[PRE REVIEW]: EditorialBot testing #143

editorialbot opened this issue Mar 24, 2024 · 63 comments

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 24, 2024

Submitting author: @luraess (Ludovic Räss)
Repository: https://github.com/luraess/JuliaConSubmission.jl
Branch with paper.md (empty if default branch):
Version: v0.1.0
Editor: @lucaferranti
Reviewers: @arfon, @matbesancon
Managing EiC: Luca Ferranti

Status

status

Status badge code:

HTML: <a href="https://proceedings.juliacon.org/papers/af2a1249d0dc82144500687dba99778f"><img src="https://proceedings.juliacon.org/papers/af2a1249d0dc82144500687dba99778f/status.svg"></a>
Markdown: [![status](https://proceedings.juliacon.org/papers/af2a1249d0dc82144500687dba99778f/status.svg)](https://proceedings.juliacon.org/papers/af2a1249d0dc82144500687dba99778f)

Author instructions

Thanks for submitting your paper to JCON @luraess. Currently, there isn't a JCON editor assigned to your paper.

@luraess if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JCON submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper source files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (920.2 files/s, 216248.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              8            271            194           2693
Ruby                             1              8              4             45
Markdown                         1             12              0             29
YAML                             1              0              0             13
TOML                             1              2              0              8
Julia                            2              3              1              7
-------------------------------------------------------------------------------
SUM:                            14            296            199           2795
-------------------------------------------------------------------------------

Commit count by author:

    13	Mathieu Besançon
     2	Christian Schilling
     2	Jeffrey Sarnoff
     2	Valentin Churavy
     1	Benoît Legat
     1	Carsten Bauer
     1	Hendrik Ranocha
     1	Jorge Pérez Zerpa
     1	Ludovic Räss
     1	Patrick Altmeyer
     1	Simon Byrne

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/141000671 is OK
- 10.1287/opre.38.5.911 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.tex is 2185

🔴 Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@lucaferranti
Copy link
Member

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

1 similar comment
@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@lucaferranti
Copy link
Member

@editorialbot add @lucaferranti as editor

@editorialbot
Copy link
Collaborator Author

I'm sorry @lucaferranti, I'm afraid I can't do that. That's something only editors are allowed to do.

@lucaferranti
Copy link
Member

@editorialbot add @matbesancon as editor

@editorialbot
Copy link
Collaborator Author

I'm sorry @lucaferranti, I'm afraid I can't do that. That's something only editors are allowed to do.

@lucaferranti
Copy link
Member

@arfon @xuanxu any idea why editorialbot does not recognize my authority? I should be in editorial board: https://proceedings.juliacon.org/about

@arfon
Copy link
Collaborator

arfon commented Mar 24, 2024

@lucaferranti editorial permissions are determined by GitHub team membership (not by the proceedings website). @xuanxu can you remind me how we figure out which team this is?

@lucaferranti
Copy link
Member

I thought the proceedings website reads the info from the same github team though?

maybe some typos in the team name somewhere?

@arfon
Copy link
Collaborator

arfon commented Mar 25, 2024

@editorialbot list editors

@editorialbot
Copy link
Collaborator Author

List of JuliaCon editors

@arfon
@fcdimitr
@lucaferranti
@luraess
@matbesancon
@odow
@pitsianis

@arfon
Copy link
Collaborator

arfon commented Mar 25, 2024

I'm sorry @lucaferranti, I'm afraid I can't do that. That's something only editors are allowed to do.

This is very weird... Can you try again @lucaferranti?

@lucaferranti
Copy link
Member

@editorialbot add @lucaferranti as editor

@editorialbot
Copy link
Collaborator Author

I'm sorry @lucaferranti, I'm afraid I can't do that. That's something only editors are allowed to do.

@lucaferranti
Copy link
Member

@arfon yep doesn't work :(

@lucaferranti
Copy link
Member

mmm I think I found the issue, here: https://github.com/openjournals/buffy/blob/juliacon/config/settings-production.yml#L9-L10

  teams:
    editors: JuliaCon/jcon-editors
    eics: JuliaCon/jcon-eics

but I believe the first team-name should be editors?

@lucaferranti
Copy link
Member

@whedon add @lucaferranti as editor

@editorialbot
Copy link
Collaborator Author

My name is now @editorialbot

@lucaferranti
Copy link
Member

@editorialbot add @lucaferranti as editor

@editorialbot
Copy link
Collaborator Author

I'm sorry @lucaferranti, I'm afraid I can't do that. That's something only editors are allowed to do.

@xuanxu
Copy link
Contributor

xuanxu commented Mar 25, 2024

Hi!
You are mixing two different things here. The teams that are authorized to do things are the ones configured under the "teams" key in line 9 of the config file.
The list of people you get when running the "list editors" command comes from a responder made to list members of a team, and that is configured en line 35 of the production config file. Right now there are two different named in those places.
(sorry by my slow anwsers, i'm on a trip without my laptop and poor internet)

@lucaferranti
Copy link
Member

lucaferranti commented Mar 25, 2024

a-haa thank you @xuanxu , that's what tricked me before.

I opened a PR to buffy to udpate the correct team name: openjournals/buffy#104

@lucaferranti
Copy link
Member

@editorialbot list reviewers

@editorialbot
Copy link
Collaborator Author

You can take a look at the list of people that have already agreed to review for JCON here.

@lucaferranti
Copy link
Member

@editorialbot list reviewers

@editorialbot
Copy link
Collaborator Author

You can take a look at the list of people that have already agreed to review for JCON here.

@lucaferranti
Copy link
Member

@editorialbot add @lucaferranti as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @lucaferranti is now the editor

@lucaferranti
Copy link
Member

@editorialbot add @arfon as reviewer

@editorialbot
Copy link
Collaborator Author

@arfon added to the reviewers list!

@lucaferranti
Copy link
Member

@editorialbot add @lucaferranti as reviewer

@editorialbot
Copy link
Collaborator Author

@lucaferranti added to the reviewers list!

@lucaferranti
Copy link
Member

@editorialbot start review

@lucaferranti
Copy link
Member

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @lucaferranti, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for branch
@editorialbot set juliacon-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Set a value for the archive DOI
@editorialbot set set 10.5281/zenodo.6861996 as archive

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Reject paper
@editorialbot reject

# Withdraw paper
@editorialbot withdraw

# Invite an editor to edit a submission (sending them an email)
@editorialbot invite @(.*) as editor

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Accept and publish the paper
@editorialbot accept

# Update data on an accepted/published paper
@editorialbot reaccept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Creates a post-review checklist with editor and authors tasks
@editorialbot create post-review checklist

# Open the review issue
@editorialbot start review

@lucaferranti
Copy link
Member

@editorialbot start review

@lucaferranti
Copy link
Member

@arfon @xuanxu new level unlocked!

Now the adding editors and reviewers works, but it seems the bot has some problems with creating / managing issues. As it does not create a new issue for the review. Any suggestions how to debug this?

@lucaferranti
Copy link
Member

@editorialbot remove @lucaferranti as reviewer

@editorialbot
Copy link
Collaborator Author

@lucaferranti removed from the reviewers list!

@lucaferranti
Copy link
Member

@editorialbot add @matbesancon as reviewer

@editorialbot
Copy link
Collaborator Author

@matbesancon added to the reviewers list!

@lucaferranti
Copy link
Member

@editorialbot start review

@lucaferranti
Copy link
Member

@editorialbot

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants