Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No custom equality testing in DIT #480

Closed
gdalle opened this issue Sep 23, 2024 · 0 comments · Fixed by #486
Closed

No custom equality testing in DIT #480

gdalle opened this issue Sep 23, 2024 · 0 comments · Fixed by #486
Labels
test Related to the testing subpackage

Comments

@gdalle
Copy link
Member

gdalle commented Sep 23, 2024 •
edited
Loading

Only isapprox can require overloading, isequal shouldn't
@gdalle gdalle added the test Related to the testing subpackage label Sep 23, 2024
@gdalle gdalle linked a pull request Sep 23, 2024 that will close this issue
Remove use of custom isequal to compare scenarios #486
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Related to the testing subpackage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove use of custom isequal to compare scenarios JuliaDiff/DifferentiationInterface.jl
1 participant
@gdalle