Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove num_bits_buffered #6

Open
dominformant opened this issue Jan 27, 2022 · 0 comments
Open

Remove num_bits_buffered #6

dominformant opened this issue Jan 27, 2022 · 0 comments

Comments

@dominformant
Copy link

dominformant commented Jan 27, 2022 •
edited
Loading

In my opinion, num_bits_buffered is no longer required. For timing, we now have num_bits_after_valid_subframe, which is actually more precise and searching for preambles after each bit would ease handling missed bits. Regarding the performance, I think we can spend the time on the additional preamble searches.

GNSSDecoder.jl/src/gpsl1_structs.jl

Lines 202 to 203 in 8550134

num_bits_buffered::Int = 0
num_bits_after_valid_subframe::Int = 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dominformant