Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reproject on a dataframe doesn't work sometimes #215

Open
asinghvi17 opened this issue Sep 20, 2024 · 1 comment
Open

reproject on a dataframe doesn't work sometimes #215

asinghvi17 opened this issue Sep 20, 2024 · 1 comment
Assignees
Labels
geocompjl Methods needed for geocompjl

Comments

@asinghvi17
Copy link
Member

reproject on a DataFrame doesn't work if the geometry column is not the first column, since it calls _is3d, which calls _is3d(first(first_row)). This is a problem, that we didn't notice till now because the geometry column was always first in dataframes.

The solution is to amend _is3d with some method on tables. However, it won't be generic, since a table might have 2D and 3D geometry.

Still, it's more important to get it working for now...

@asinghvi17 asinghvi17 self-assigned this Sep 20, 2024
@asinghvi17 asinghvi17 added the geocompjl Methods needed for geocompjl label Sep 20, 2024
@asinghvi17 asinghvi17 changed the title reproject on a dataframe doesn't work reproject on a dataframe doesn't work sometimes Sep 20, 2024
@rafaqz
Copy link
Member

rafaqz commented Sep 20, 2024

Ah that's a bug in _is3d that got through tests because we put geometry in the first row

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
geocompjl Methods needed for geocompjl
Projects
None yet
Development

No branches or pull requests

2 participants