Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing functions #109

Open
nraynaud opened this issue May 24, 2022 · 3 comments
Open

missing functions #109

nraynaud opened this issue May 24, 2022 · 3 comments

Comments

@nraynaud
Copy link
Contributor

nraynaud commented May 24, 2022

Hi, it's me again, I don't see the offsetCurve() function in the library, only a reference here:
https://github.com/JuliaGeo/LibGEOS.jl/blob/master/src/geos_functions.jl#L340

is there something that makes it impossible or complicated to expose in libGEOS ?

list of mising functions so far:

  • offsetCurve()
  • lineMerge()
@nraynaud nraynaud changed the title missing offsetCurve function missing offsetCurve() function May 24, 2022
@visr
Copy link
Member

visr commented May 24, 2022

As far as I'm aware for none of the methods there is a reason it is impossible or complicated to expose.
It would be good to collect all of them together in an issue, such that we can tackle them one by one. (e.g. #108)

Another method that perhaps would require a bit more time upfront but might make maintenance easier would be to generate the code automatically, in a similar way we do for instance for Proj.jl (https://github.com/JuliaGeo/Proj4.jl/blob/e50a7d7fad6280e719398be43668264649707c29/gen/generator.jl#L11)

@nraynaud nraynaud changed the title missing offsetCurve() function missing functions May 24, 2022
@nraynaud
Copy link
Contributor Author

thank you. I feel way too green in Julia to generate an API, but I can probably copy/paste something together to add a function the same way the current ones are exposed.

@visr
Copy link
Member

visr commented May 24, 2022

That would be a great first contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants