Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoInterface cleanup needed #194

Open
rafaqz opened this issue Jan 1, 2024 · 2 comments
Open

GeoInterface cleanup needed #194

rafaqz opened this issue Jan 1, 2024 · 2 comments

Comments

@rafaqz
Copy link
Member

rafaqz commented Jan 1, 2024

I noticed a bunch of weird stuff in the geo_interface.jl file during other PRs, like:

GeoInterface.getgeom(t::AbstractPointTrait, geom::PreparedGeometry, i) = 0

GeoInterface.getgeom(t::AbstractPointTrait, geom::PreparedGeometry) = nothing

GeoInterface.coordinates(t::AbstractPointTrait, geom::AbstractGeometry) = nothing

It could also do with some organization and comments

@rafaqz rafaqz changed the title GeoInterface cleanup GeoInterface cleanup needed Jan 1, 2024
@evetion
Copy link
Member

evetion commented Jan 2, 2024

Agreed. The zero seems like a wrong copy. The other two might be required for Aqua? Good to test though.

@rafaqz
Copy link
Member Author

rafaqz commented Jan 2, 2024

I wondered that too, they at least need "ambiguity" comments if so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants