-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an extended tag for time-intensive unit tests #109
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
===========================================
- Coverage 100.00% 95.76% -4.24%
===========================================
Files 17 17
Lines 260 260
===========================================
- Hits 260 249 -11
- Misses 0 11 +11 ☔ View full report in Codecov by Sentry. |
We're down to <10 minute CI times just by pushing two geometry types into |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we put the test for a wrong number of parametric coordinates into another @testitem
to keep at least that one covered? It currently is in the 4D Box test (lines 199-200), but could also live somewhere else.
Good catch! I just moved it from 4D to 2D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Changes
:extended
@testitem
tag for time-intensive tests that can forgo CI (still available for local testing in VS Code)Box in 4D
andTetrahedron
This comes with the downside that integration of these two geometry types won’t be checked automatically with CI, and a code coverage “reduction”, but I think the actual practical impact is minor. For any changes that would specifically impact these two geometries, we’ll have to make sure to run the tests locally. Slightly inconvenient for a niche case but allows for faster iterations in development of everything else.