Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an extended tag for time-intensive unit tests #109

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

mikeingold
Copy link
Collaborator

@mikeingold mikeingold commented Oct 14, 2024

Changes

  • Establishes an :extended @testitem tag for time-intensive tests that can forgo CI (still available for local testing in VS Code)
    • Tagged Box in 4D and Tetrahedron

This comes with the downside that integration of these two geometry types won’t be checked automatically with CI, and a code coverage “reduction”, but I think the actual practical impact is minor. For any changes that would specifically impact these two geometries, we’ll have to make sure to run the tests locally. Slightly inconvenient for a niche case but allows for faster iterations in development of everything else.

@mikeingold mikeingold added enhancement New feature or request testing labels Oct 14, 2024
@mikeingold mikeingold linked an issue Oct 14, 2024 that may be closed by this pull request
1 task
test/runtests.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (87ac32d) to head (844cffd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #109      +/-   ##
===========================================
- Coverage   100.00%   95.76%   -4.24%     
===========================================
  Files           17       17              
  Lines          260      260              
===========================================
- Hits           260      249      -11     
- Misses           0       11      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeingold
Copy link
Collaborator Author

We're down to <10 minute CI times just by pushing two geometry types into :extended test sets. 😃

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mikeingold mikeingold marked this pull request as ready for review October 14, 2024 21:17
Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we put the test for a wrong number of parametric coordinates into another @testitem to keep at least that one covered? It currently is in the 4D Box test (lines 199-200), but could also live somewhere else.

@mikeingold
Copy link
Collaborator Author

Good catch! I just moved it from 4D to 2D

Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mikeingold mikeingold merged commit aa0270a into main Oct 15, 2024
13 of 15 checks passed
@mikeingold mikeingold deleted the tests-extended branch October 15, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test completion could be faster
2 participants