Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to _default_method #146

Closed
mikeingold opened this issue Dec 2, 2024 · 1 comment · Fixed by #147
Closed

Changes to _default_method #146

mikeingold opened this issue Dec 2, 2024 · 1 comment · Fixed by #147

Comments

@mikeingold
Copy link
Collaborator

Background

The _default_method utility function currently takes a (::Geometry) or (::Type{<:Geometry}) as argument since it depended on the geometry being integrated. PR #139 potentially makes this obsolete by removing Analytical and making FiniteDifference the universal default.

Ideas

I think the function should be renamed _default_diff_method for clarity.

Should this function continue to take geometry-information as an argument? We're not currently using that information, but it's possible that could change again in the future as more DifferentiationMethods are implemented.

@JoshuaLampert
Copy link
Member

JoshuaLampert commented Dec 2, 2024

I think it doesn't harm if _default_method takes a geometry. It shouldn't decrease performance, but allows for more flexibility in the future. I agree that renaming it to _default_diff_method makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants