-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a changelog #158
Add a changelog #158
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 184 184
=========================================
Hits 184 184 ☔ View full report in Codecov by Sentry. |
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
I like it! Especially in view of the recent changes to the requirements for registering breaking releases in the General registry. In future, we can, e.g., point to the changelog in the release notes. |
This was actually inspired by the recent thread on Julia Discourse.
I saw that package referenced in the Discourse thread. Is there more to it than just automatically generating links? If not, I don't mind just manually adding links where relevant. |
I think it would be nice to have the changelog also in the docs for more visibility. To achieve this we have different options. We need a markdown file under Changelog.generate(Changelog.Documenter(), # output type
joinpath(@__DIR__, "..", "CHANGELOG.md"), # input file
joinpath(@__DIR__, "src", "changelog.md"); # output file
repo = "JuliaGeometry/MeshIntegrals.jl", # default repository for links
branch = "main",) to
|
I'm not an expert in GitHub and these automations, but could we simply create a symlink like |
Could maybe work. I've never tried that. |
I can give it a shot here and see what happens. |
Looks like it worked! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
Added
CHANGELOG.md