Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument Parsing for Type Stability #11

Open
sjkelly opened this issue Sep 25, 2019 · 0 comments
Open

Argument Parsing for Type Stability #11

sjkelly opened this issue Sep 25, 2019 · 0 comments

Comments

@sjkelly
Copy link
Member

sjkelly commented Sep 25, 2019

It seems as though this line is triggering some type instability:

TetGen.jl/src/cppwrapper.jl

Lines 290 to 296 in 4ce1bd5

function Base.convert(::Type{TetgenIO}, io::CPPTetgenIO{T}) where T
NSimplex = Int(io.numberofcorners)
NAttributes = Int(io.numberofpointattributes)
NMTr = Int(io.numberofpointmtrs)
IT = inttype(T) # TODO these are indices,
convert(TetgenIO{T, NSimplex, NAttributes, NMTr, IT, Vector{CFacet{T}}}, io)
end

One solution towards this is parsing of the arguments to determine the actual type parameters in the tetrahedralize function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant