Upgrade HTTP compatibility #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous CIDs being matched in the test do not exist in the PubChem database. Consequently, when testing on the PubChem website directly instead of using the BrokenRecord files, the tests were failing. With this change tests do not fail anymore, as I replaced the erroneous CID with one that exists in PubChem.
timholy
added a commit
that referenced
this pull request
Aug 30, 2024
Closes #19, closes #21 Co-authored by: Filipe Chichorro <[email protected]>
|
Many thanks for your contributions! Sorry I wasn't paying attention when you submitted these fixes. PubChemCrawler 1.2.0 should be out shortly after #21 merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added HTTP.jl version 1.9.2 to the compat in Project.toml. I also replaced the test/http_record files because the previous ones were outdated and not working anymore when updating to 1.9.2. The tests work out provided #18 is merged.
Also, I was thinking that maybe HTTP versions 0.8 and 0.9 could be dropped from the Project.toml? Seems like those are pretty old versions of HTTP to be supported. I was also not sure whether I should add 1.9.2 or plain v1 to the compat entry, to reduce the probability of compatibility issues with other packages.