Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Julia 1.7 performance regression on rawview #174

Closed
johnnychen94 opened this issue Dec 1, 2021 · 1 comment · May be fixed by #175
Closed

Julia 1.7 performance regression on rawview #174

johnnychen94 opened this issue Dec 1, 2021 · 1 comment · May be fixed by #175
Labels
performance

Comments

@johnnychen94
Copy link
Member

johnnychen94 commented Dec 1, 2021 •
edited by ViralBShah
Loading

Looks like it's either MappedArrays or Julia Base issue

using ImageCore, BenchmarkTools
dst = rawview(channelview(rand(RGB{N0f8}, 64, 64)));
src = copy(dst);
@btime copyto!($dst, $src);
# 1.7.0: 1.209 ms (49152 allocations: 1.69 MiB)
# 1.6.5: 55.287 μs (0 allocations: 0 bytes)
This was referenced Dec 1, 2021
Closed
Closed
Open
@ViralBShah
Copy link
Contributor 

julia> dst = rawview(channelview(rand(RGB{N0f8}, 64, 64)));

julia> src = copy(dst);

julia> @btime copyto!($dst, $src);
       # 1.7.0: 1.209 ms (49152 allocations: 1.69 MiB)
       # 1.6.5: 55.287 μs (0 allocations: 0 bytes)
  10.125 μs (0 allocations: 0 bytes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unwrap rawview(::channelview) with one reshape reinterpret JuliaImages/ImageCore.jl
2 participants
@ViralBShah @johnnychen94