Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization of the source code for the wrappers #49

Open
ViralBShah opened this issue Oct 25, 2024 · 1 comment
Open

Organization of the source code for the wrappers #49

ViralBShah opened this issue Oct 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ViralBShah
Copy link
Contributor

Currently, the way we build this package is that opencv and opencv-contrib are both recipes in the Yggdrasil repo. The code in contrib generates the wrappers for the Julia package.

It probably would be better to have the contrib stuff in this repo and generate the julia wrapper code independent of the opencv binary build. I do not know if it has dependencies on the opencv build process itself. Just thought I would leave it here.

@barche Any thoughts on this based on your recent experience?

@barche
Copy link

barche commented Oct 25, 2024

I would proceed as follows:

  • move all Julia code out of opencv_contrib and into this repository
  • keep the c++ code in opencv_contrib to ensure compatibility with the corresponding OpenCV

From what I can see most of the C++ is generated from within the OpenCV build system, so it’s easier to leave it there.

@rakeshksr rakeshksr added the enhancement New feature or request label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants