From 8dc437ffac9b58bac6b83055ed26ceda04ad4287 Mon Sep 17 00:00:00 2001 From: Ronny Bergmann Date: Mon, 30 Dec 2024 17:10:40 +0100 Subject: [PATCH] add the remaining tests. --- src/plans/vectorial_plan.jl | 6 +----- test/plans/test_vectorial_plan.jl | 2 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/plans/vectorial_plan.jl b/src/plans/vectorial_plan.jl index 90a2ba9302..c35729cd24 100644 --- a/src/plans/vectorial_plan.jl +++ b/src/plans/vectorial_plan.jl @@ -1164,11 +1164,7 @@ function get_value!( i=:, ) c = vgf.value!!(M, p) - if isa(c, Number) - V .= c - else - V .= c[i] - end + V .= c[i] return V end diff --git a/test/plans/test_vectorial_plan.jl b/test/plans/test_vectorial_plan.jl index 0f3b25a1ef..745ad25982 100644 --- a/test/plans/test_vectorial_plan.jl +++ b/test/plans/test_vectorial_plan.jl @@ -57,6 +57,8 @@ using Manopt: get_value, get_value_function, get_gradient_function jacobian_type=CoordinateVectorialType(DefaultOrthonormalBasis()), evaluation=InplaceEvaluation(), ) + @test Manopt.get_jacobian_basis(vgf_ji) == vgf_ji.jacobian_type.basis + @test Manopt.get_jacobian_basis(vgf_vi) == DefaultOrthonormalBasis() p = [1.0, 2.0, 3.0] c = [0.0, -3.0] gg = [[1.0, 0.0, 0.0], [0.0, -1.0, 0.0]]