Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Tutorial when starting with a new manifold #314

Merged
merged 17 commits into from
Nov 19, 2023

Conversation

kellertuer
Copy link
Member

@kellertuer kellertuer commented Nov 6, 2023

This is an approach to resolve #305.

Maybe it is also a good idea on this PR to first have a few more “Technical Details” pages per solver similar to https://manoptjl.org/stable/solvers/gradient_descent.html#Technical-Details.

  • finished a new tutorial
  • introduce vale.sh to reduce errors and formatting in docs – though for now just in md files not yet in doc strings.
  • add “Technical Details” sections to other solvers
    • ARC solver
    • alternating gradient descent
    • ALM
    • Chambolle–Pock
    • CG
    • DoC
    • DouglasRachford
    • EPM
    • gradient descent
    • Levenbeg–Marquardt
    • Nelder–Mead
    • particle swarm
    • primal dual semi smooth Newton
    • quasi Newton
    • SGD
    • tCG
    • trust regions

@kellertuer kellertuer added documentation WIP Work in Progress (for a pull request) labels Nov 6, 2023
@kellertuer kellertuer self-assigned this Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1fc4a5) 99.74% compared to head (77d8768) 99.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          79       79           
  Lines        7353     7353           
=======================================
  Hits         7334     7334           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellertuer
Copy link
Member Author

@blegat before continuing with more technical details sections (they take a bit of time not to miss a function) – can you check whether a tutorial like https://manoptjl.org/previews/PR314/tutorials/ImplementOwnManifold.html is what you would have liked to have?

@blegat
Copy link
Contributor

blegat commented Nov 11, 2023

Yes, it's exactly what I had in mind!

@kellertuer
Copy link
Member Author

kellertuer commented Nov 11, 2023

Great! Then I will carefully add the technical details sections for the other solvers as well; probably also for step sizes and debugs.

@kellertuer
Copy link
Member Author

While a few might still be challenging (Chambolle-Pock), I think most (CG, SGD, EPM,...) will just be copies of gradient descent in the technical details. Still good to check them.

And since I am redoing the docs a bit anyways, I will also try to minimise Vale warnings along the way (we at least do not have Vale errors any longer by now).

@kellertuer kellertuer added enhancement Ready-for-Review A label for pull requests that are feature-ready and removed WIP Work in Progress (for a pull request) labels Nov 18, 2023
@kellertuer
Copy link
Member Author

I now added a technical section to all solvers that lists (and currently also explains a bit) which functions are required what for. One could maybe shorten that to just listing functions.

Besides that I will maybe wait a day or two whether vale will get Julia code/docstring support and reiterate here again then. If they are not that fast I might just merge this for now.

@kellertuer kellertuer marked this pull request as ready for review November 18, 2023 13:51
@kellertuer kellertuer merged commit a086b7a into master Nov 19, 2023
15 checks passed
@kellertuer kellertuer deleted the kellertuer/doc-improvements branch December 16, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial when to write an own manifold
2 participants