-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Tutorial when starting with a new manifold #314
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 79 79
Lines 7353 7353
=======================================
Hits 7334 7334
Misses 19 19 ☔ View full report in Codecov by Sentry. |
@blegat before continuing with more technical details sections (they take a bit of time not to miss a function) – can you check whether a tutorial like https://manoptjl.org/previews/PR314/tutorials/ImplementOwnManifold.html is what you would have liked to have? |
Yes, it's exactly what I had in mind! |
Great! Then I will carefully add the technical details sections for the other solvers as well; probably also for step sizes and debugs. |
While a few might still be challenging (Chambolle-Pock), I think most (CG, SGD, EPM,...) will just be copies of gradient descent in the technical details. Still good to check them. And since I am redoing the docs a bit anyways, I will also try to minimise Vale warnings along the way (we at least do not have Vale errors any longer by now). |
I now added a technical section to all solvers that lists (and currently also explains a bit) which functions are required what for. One could maybe shorten that to just listing functions. Besides that I will maybe wait a day or two whether vale will get Julia code/docstring support and reiterate here again then. If they are not that fast I might just merge this for now. |
This is an approach to resolve #305.
Maybe it is also a good idea on this PR to first have a few more “Technical Details” pages per solver similar to https://manoptjl.org/stable/solvers/gradient_descent.html#Technical-Details.